Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 017bbc09 authored by Tony Wickham's avatar Tony Wickham
Browse files

Don't moveToRestState from onTaskAppeared 

There's a possible race here where we call moveToRestState before
Launcher is actually stopped, so it starts to animate the state
change, causing a visual jump before it gets stopped. We already call
moveToRestState in StatefulActivity#onStop, so this one shouldn't be
necessary anyway.

Test: Enable Winscope tracing, quick switch from app A to app B; before
this change, 9/10 times it would repro the jump in the bug, 0/10 times
after this fix. (Also verified through debug logging.)
Fixes: 244583136

Change-Id: I656b028f26a64f872960cb3fe87c39b097431511
parent 4298b36e

quickstep/src/com/android/quickstep/AbsSwipeUpHandler.java

+0 −1
Original line number Diff line number Diff line
@@ -2070,7 +2070,6 @@ public abstract class AbsSwipeUpHandler<T extends StatefulActivity<S>, 
            if (handleTaskAppeared(appearedTaskTargets)) {

                mRecentsAnimationController.finish(false /* toRecents */,

                        null /* onFinishComplete */);

                mActivityInterface.onLaunchTaskSuccess();

                ActiveGestureLog.INSTANCE.addLog(

                        /* event= */ "finishRecentsAnimation",

                        /* extras= */ false,

quickstep/src/com/android/quickstep/BaseActivityInterface.java

+0 −8
Original line number Diff line number Diff line
@@ -183,14 +183,6 @@ public abstract class BaseActivityInterface<STATE_TYPE extends BaseState<STATE_T 


    public abstract void onLaunchTaskFailed();



    public void onLaunchTaskSuccess() {

        ACTIVITY_TYPE activity = getCreatedActivity();

        if (activity == null) {

            return;

        }

        activity.getStateManager().moveToRestState();

    }



    /**

     * Closes any overlays.

     */