From 014168183528615c8d6a644e5db5221b80772919 Mon Sep 17 00:00:00 2001
From: Fahim Salam Chowdhury <fahim@e.email>
Date: Wed, 12 Oct 2022 13:22:50 +0600
Subject: [PATCH] 745-Fix_UI_issue_in_dark_mode

issue: https://gitlab.e.foundation/e/os/backlog/-/issues/745
---
 app/src/main/res/layout/about_translation.xml |  4 ++--
 .../main/res/layout/account_collections.xml   |  2 ++
 app/src/main/res/layout/account_list.xml      |  2 ++
 .../res/layout/activity_add_webdav_mount.xml  |  1 +
 .../main/res/layout/activity_debug_info.xml   | 20 ++++++++++++++-----
 app/src/main/res/layout/activity_tasks.xml    |  2 +-
 .../layout/intro_battery_optimizations.xml    | 12 ++++++-----
 .../main/res/layout/webdav_mounts_item.xml    |  1 +
 8 files changed, 31 insertions(+), 13 deletions(-)

diff --git a/app/src/main/res/layout/about_translation.xml b/app/src/main/res/layout/about_translation.xml
index 37687d6cb..b0d857024 100644
--- a/app/src/main/res/layout/about_translation.xml
+++ b/app/src/main/res/layout/about_translation.xml
@@ -3,14 +3,14 @@
     android:layout_width="match_parent"
     android:layout_height="wrap_content"
     xmlns:tools="http://schemas.android.com/tools"
-    xmlns:app="http://schemas.android.com/apk/res-auto"
-    app:contentPadding="@dimen/card_padding"
     android:layout_marginTop="8dp"
     android:layout_marginBottom="8dp">
 
     <LinearLayout
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
+        android:padding="@dimen/card_padding"
+        android:background="@color/foregroundColor"
         android:orientation="vertical">
 
         <TextView
diff --git a/app/src/main/res/layout/account_collections.xml b/app/src/main/res/layout/account_collections.xml
index afd428555..54defa1ac 100644
--- a/app/src/main/res/layout/account_collections.xml
+++ b/app/src/main/res/layout/account_collections.xml
@@ -32,6 +32,7 @@
                 android:layout_width="match_parent"
                 android:layout_height="wrap_content"
                 android:padding="@dimen/card_padding"
+                android:background="@color/foregroundColor"
                 android:orientation="horizontal">
                 <TextView
                     android:id="@+id/permissionsText"
@@ -52,6 +53,7 @@
                     app:layout_constraintEnd_toEndOf="parent"
                     app:layout_constraintBottom_toBottomOf="parent"
                     style="@style/Widget.MaterialComponents.Button.TextButton"
+                    android:textColor="@color/primaryTextColor"
                     android:text="@string/account_permissions_action" />
             </androidx.constraintlayout.widget.ConstraintLayout>
         </com.google.android.material.card.MaterialCardView>
diff --git a/app/src/main/res/layout/account_list.xml b/app/src/main/res/layout/account_list.xml
index 18078361a..1c5c33bc2 100644
--- a/app/src/main/res/layout/account_list.xml
+++ b/app/src/main/res/layout/account_list.xml
@@ -31,6 +31,7 @@
                 android:layout_width="wrap_content"
                 android:layout_height="wrap_content"
                 style="@style/Widget.MaterialComponents.Button.TextButton"
+                android:textColor="@color/primaryTextColor"
                 android:text="Manage connections" />
 
         </LinearLayout>
@@ -63,6 +64,7 @@
                 android:layout_width="wrap_content"
                 android:layout_height="wrap_content"
                 style="@style/Widget.MaterialComponents.Button.TextButton"
+                android:textColor="@color/primaryTextColor"
                 android:text="Manage storage" />
 
         </LinearLayout>
diff --git a/app/src/main/res/layout/activity_add_webdav_mount.xml b/app/src/main/res/layout/activity_add_webdav_mount.xml
index 2797006ca..67c0b5dc9 100644
--- a/app/src/main/res/layout/activity_add_webdav_mount.xml
+++ b/app/src/main/res/layout/activity_add_webdav_mount.xml
@@ -119,6 +119,7 @@
                 android:layout_width="wrap_content"
                 android:layout_height="wrap_content"
                 android:layout_gravity="end"
+                android:textColor="@color/primaryTextColor"
                 android:text="@string/webdav_add_mount_add" />
 
         </androidx.cardview.widget.CardView>
diff --git a/app/src/main/res/layout/activity_debug_info.xml b/app/src/main/res/layout/activity_debug_info.xml
index fd3ab5dc8..ac6abe3b9 100644
--- a/app/src/main/res/layout/activity_debug_info.xml
+++ b/app/src/main/res/layout/activity_debug_info.xml
@@ -22,6 +22,7 @@
                 <LinearLayout
                     android:layout_width="match_parent"
                     android:layout_height="wrap_content"
+                    android:background="@color/backgroundColor"
                     android:layout_margin="@dimen/activity_margin"
                     android:orientation="vertical">
 
@@ -42,7 +43,8 @@
                         <androidx.constraintlayout.widget.ConstraintLayout
                             android:layout_width="match_parent"
                             android:layout_height="wrap_content"
-                            android:layout_marginBottom="@dimen/card_padding">
+                            android:background="@color/foregroundColor"
+                            android:paddingBottom="@dimen/card_padding">
 
                             <androidx.constraintlayout.widget.Guideline
                                 android:id="@+id/zipStart"
@@ -124,6 +126,7 @@
                                 app:layout_constraintBottom_toBottomOf="parent"
                                 style="@style/Widget.MaterialComponents.Button.TextButton"
                                 android:enabled="@{model.debugInfo != null &amp;&amp; !model.zipProgress}"
+                                android:textColor="@color/primaryTextColor"
                                 android:text="@string/debug_info_archive_share" />
 
                         </androidx.constraintlayout.widget.ConstraintLayout>
@@ -139,7 +142,8 @@
                         <androidx.constraintlayout.widget.ConstraintLayout
                             android:layout_width="match_parent"
                             android:layout_height="wrap_content"
-                            android:layout_marginBottom="@dimen/card_padding"
+                            android:paddingBottom="@dimen/card_padding"
+                            android:background="@color/foregroundColor"
                             android:orientation="vertical">
 
                             <androidx.constraintlayout.widget.Guideline
@@ -224,6 +228,7 @@
                                 app:layout_constraintLeft_toLeftOf="@id/causeStart"
                                 app:layout_constraintBottom_toBottomOf="parent"
                                 style="@style/Widget.MaterialComponents.Button.TextButton"
+                                android:textColor="@color/primaryTextColor"
                                 android:text="@string/debug_info_view_details"/>
 
                         </androidx.constraintlayout.widget.ConstraintLayout>
@@ -239,7 +244,8 @@
                         <androidx.constraintlayout.widget.ConstraintLayout
                             android:layout_width="match_parent"
                             android:layout_height="wrap_content"
-                            android:layout_marginBottom="@dimen/card_padding"
+                            android:paddingBottom="@dimen/card_padding"
+                            android:background="@color/foregroundColor"
                             android:orientation="vertical">
 
                             <androidx.constraintlayout.widget.Guideline
@@ -312,6 +318,7 @@
                                 app:layout_constraintLeft_toLeftOf="@id/debugInfoStart"
                                 app:layout_constraintBottom_toBottomOf="parent"
                                 style="@style/Widget.MaterialComponents.Button.TextButton"
+                                android:textColor="@color/primaryTextColor"
                                 android:text="@string/debug_info_view_details"/>
 
                         </androidx.constraintlayout.widget.ConstraintLayout>
@@ -327,7 +334,8 @@
                         <androidx.constraintlayout.widget.ConstraintLayout
                             android:layout_width="match_parent"
                             android:layout_height="wrap_content"
-                            android:layout_margin="@dimen/card_padding">
+                            android:background="@color/foregroundColor"
+                            android:padding="@dimen/card_padding">
 
                             <ImageView
                                 android:id="@+id/resIcon"
@@ -420,7 +428,8 @@
                         <androidx.constraintlayout.widget.ConstraintLayout
                             android:layout_width="match_parent"
                             android:layout_height="wrap_content"
-                            android:layout_margin="@dimen/card_padding">
+                            android:background="@color/foregroundColor"
+                            android:padding="@dimen/card_padding">
 
                             <ImageView
                                 android:id="@+id/logsIcon"
@@ -464,6 +473,7 @@
                                 app:layout_constraintLeft_toLeftOf="parent"
                                 app:layout_constraintBottom_toBottomOf="parent"
                                 style="@style/Widget.MaterialComponents.Button.TextButton"
+                                android:textColor="@color/primaryTextColor"
                                 android:text="@string/debug_info_logs_view"/>
 
                         </androidx.constraintlayout.widget.ConstraintLayout>
diff --git a/app/src/main/res/layout/activity_tasks.xml b/app/src/main/res/layout/activity_tasks.xml
index 98ae2209e..51730f42e 100644
--- a/app/src/main/res/layout/activity_tasks.xml
+++ b/app/src/main/res/layout/activity_tasks.xml
@@ -28,7 +28,7 @@
                 <androidx.constraintlayout.widget.ConstraintLayout
                     android:layout_width="match_parent"
                     android:layout_height="wrap_content"
-                    android:layout_marginBottom="@dimen/card_padding"
+                    android:paddingBottom="@dimen/card_padding"
                     android:background="@color/foregroundColor">
 
                     <at.bitfire.davdroid.ui.widget.CropImageView
diff --git a/app/src/main/res/layout/intro_battery_optimizations.xml b/app/src/main/res/layout/intro_battery_optimizations.xml
index 8572e2f52..407a85d4f 100644
--- a/app/src/main/res/layout/intro_battery_optimizations.xml
+++ b/app/src/main/res/layout/intro_battery_optimizations.xml
@@ -22,12 +22,13 @@
             <com.google.android.material.card.MaterialCardView
                 android:layout_width="match_parent"
                 android:layout_height="wrap_content"
-                app:contentPadding="@dimen/card_padding"
                 android:background="@color/foregroundColor">
 
                 <androidx.constraintlayout.widget.ConstraintLayout
                     android:layout_width="match_parent"
-                    android:layout_height="wrap_content">
+                    android:layout_height="wrap_content"
+                    android:padding="@dimen/card_padding"
+                    android:background="@color/foregroundColor">
 
                     <TextView
                         android:id="@+id/batteryHeading"
@@ -94,12 +95,13 @@
                 android:layout_width="match_parent"
                 android:layout_height="wrap_content"
                 android:layout_marginTop="8dp"
-                android:visibility="@{model.Companion.manufacturerWarning ? View.VISIBLE : View.GONE}"
-                app:contentPadding="@dimen/card_padding">
+                android:visibility="@{model.Companion.manufacturerWarning ? View.VISIBLE : View.GONE}">
 
                 <androidx.constraintlayout.widget.ConstraintLayout
                     android:layout_width="match_parent"
-                    android:layout_height="wrap_content">
+                    android:layout_height="wrap_content"
+                    android:background="@color/foregroundColor"
+                    android:padding="@dimen/card_padding">
 
                     <TextView
                         android:id="@+id/autostartHeading"
diff --git a/app/src/main/res/layout/webdav_mounts_item.xml b/app/src/main/res/layout/webdav_mounts_item.xml
index 627b2105d..5e41d3ee5 100644
--- a/app/src/main/res/layout/webdav_mounts_item.xml
+++ b/app/src/main/res/layout/webdav_mounts_item.xml
@@ -66,6 +66,7 @@
                 android:layout_width="wrap_content"
                 android:layout_height="wrap_content"
                 style="@style/Widget.MaterialComponents.Button.TextButton"
+                android:textColor="@color/primaryTextColor"
                 android:text="@string/webdav_mounts_share_content" />
 
             <ImageButton
-- 
GitLab