From 6966ae282d2cf7944e48103489d9c454e13705b4 Mon Sep 17 00:00:00 2001
From: Akhil <akhil.potukuchi@gmail.com>
Date: Mon, 13 Jan 2025 13:26:06 +0530
Subject: [PATCH 1/2] Search SSO API endpoint with email instead of username

---
 lib/Service/SSOService.php | 17 ++++++++++++++---
 1 file changed, 14 insertions(+), 3 deletions(-)

diff --git a/lib/Service/SSOService.php b/lib/Service/SSOService.php
index 896b2d20..a6cb4d23 100644
--- a/lib/Service/SSOService.php
+++ b/lib/Service/SSOService.php
@@ -8,6 +8,7 @@ use OCA\EcloudAccounts\Exception\SSOAdminAccessTokenException;
 use OCA\EcloudAccounts\Exception\SSOAdminAPIException;
 use OCP\IConfig;
 use OCP\ILogger;
+use OCP\IUserManager;
 use OCP\L10N\IFactory;
 use OCP\Security\ICrypto;
 
@@ -21,12 +22,13 @@ class SSOService {
 	private string $currentUserId;
 	private ICrypto $crypto;
 	private IFactory $l10nFactory;
+	private IUserManager $userManager;
 
 	private const ADMIN_TOKEN_ENDPOINT = '/auth/realms/master/protocol/openid-connect/token';
 	private const USERS_ENDPOINT = '/users';
 	private const CREDENTIALS_ENDPOINT = '/users/{USER_ID}/credentials';
 
-	public function __construct($appName, IConfig $config, CurlService $curlService, ICrypto $crypto, IFactory $l10nFactory, ILogger $logger) {
+	public function __construct($appName, IConfig $config, CurlService $curlService, ICrypto $crypto, IFactory $l10nFactory, IUserManager $userManager, ILogger $logger) {
 		$this->appName = $appName;
 		$this->config = $config;
 
@@ -45,6 +47,7 @@ class SSOService {
 		$this->curl = $curlService;
 		$this->logger = $logger;
 		$this->l10nFactory = $l10nFactory;
+		$this->userManager = $userManager;
 	}
 
 	public function shouldSync2FA() : bool {
@@ -147,8 +150,16 @@ class SSOService {
 	}
 
 	private function getUserId(string $username) : void {
-		$usernameWithoutDomain = explode('@', $username)[0];
-		$url = $this->ssoConfig['admin_rest_api_url'] . self::USERS_ENDPOINT . '?exact=true&username=' . $usernameWithoutDomain;
+		$user = $this->userManager->get($username);
+		if ($user === null) {
+			throw new SSOAdminAPIException('Error: no user exists in cloud with username ' . $username);
+		}
+		$email = $user->getEMailAddress();
+		if ($email === null) {
+			throw new SSOAdminAPIException('Error: user with username ' . $username . ' does not have email field set');
+		}
+
+		$url = $this->ssoConfig['admin_rest_api_url'] . self::USERS_ENDPOINT . '?exact=true&email=' . $email;
 		$this->logger->debug('getUserId calling SSO API with url: '. $url);
 		$users = $this->callSSOAPI($url, 'GET');
 		if (empty($users) || !is_array($users) || !isset($users[0])) {
-- 
GitLab


From 7336896a6e0bae76e78d24ddbe248ee64443d67f Mon Sep 17 00:00:00 2001
From: Akhil <akhil.potukuchi@gmail.com>
Date: Tue, 14 Jan 2025 18:33:04 +0530
Subject: [PATCH 2/2] Bump version to 8.0.4

---
 appinfo/info.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/appinfo/info.xml b/appinfo/info.xml
index 35a9b216..88fad061 100644
--- a/appinfo/info.xml
+++ b/appinfo/info.xml
@@ -10,7 +10,7 @@
     <description><![CDATA[in /e/OS cloud, nextcloud accounts are linked to mail accounts. This app ensures both are coordinated: it sets the e-mail address, quota and storage of the user upon creation.
     It also completes the account deletion by cleaning other parts of the /e/OS cloud setup to ensure no more data is retained when a user requests an account deletion.
     This app uses the UserDeletedEvent to invoke scripts in the docker-welcome container of /e/OS cloud setup]]></description>
-    <version>8.0.3</version>
+    <version>8.0.4</version>
     <licence>agpl</licence>
     <author mail="dev@murena.com" homepage="https://murena.com/">Murena SAS</author>
     <namespace>EcloudAccounts</namespace>
-- 
GitLab