From eee4c2b74d9bfd83a78a37aeee033a000206c783 Mon Sep 17 00:00:00 2001 From: Ronak Patel Date: Thu, 10 Mar 2022 17:50:01 +0530 Subject: [PATCH 1/6] resolve issue with 0 percentage --- src/Helpers/Build.php | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/Helpers/Build.php b/src/Helpers/Build.php index fd97512..772a4cc 100644 --- a/src/Helpers/Build.php +++ b/src/Helpers/Build.php @@ -548,12 +548,13 @@ public function checkRollout() { $rolloutpercentage = isset($this->confProp['rollout']['percentage']) ? $this->confProp['rollout']['percentage'] : 100; - if ($rolloutpercentage >= 0 && $rolloutpercentage < 100) { - $rand_number = rand(0, 100); - if ($rand_number > $rolloutpercentage) { - return false; - } + if ($rolloutpercentage <= 0 || $rolloutpercentage > 100) { + return FALSE; + } + $rand_number = rand(1, 100); + if ($rand_number > $rolloutpercentage) { + return FALSE; } - return true; + return TRUE; } } \ No newline at end of file -- GitLab From 13e7b6a63706e89f6cd580cb993ae5a58aaefbb7 Mon Sep 17 00:00:00 2001 From: Ronak Patel Date: Fri, 11 Mar 2022 13:13:40 +0530 Subject: [PATCH 2/6] resolve issue with 0 percentage --- src/Helpers/Build.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Helpers/Build.php b/src/Helpers/Build.php index 772a4cc..352b6c5 100644 --- a/src/Helpers/Build.php +++ b/src/Helpers/Build.php @@ -547,9 +547,9 @@ */ public function checkRollout() { - $rolloutpercentage = isset($this->confProp['rollout']['percentage']) ? $this->confProp['rollout']['percentage'] : 100; + $rolloutpercentage = isset($this->confProp['rollout']['percentage']) ? (int) $this->confProp['rollout']['percentage'] : 100; if ($rolloutpercentage <= 0 || $rolloutpercentage > 100) { - return FALSE; + $rolloutpercentage = 100; } $rand_number = rand(1, 100); if ($rand_number > $rolloutpercentage) { -- GitLab From 9e74c6f7b8513f0abb509c5e4a219410adac1c00 Mon Sep 17 00:00:00 2001 From: Ronak Patel Date: Fri, 11 Mar 2022 14:39:06 +0530 Subject: [PATCH 3/6] resolve issue with 0 percentage --- src/Helpers/Build.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Helpers/Build.php b/src/Helpers/Build.php index 352b6c5..e873d83 100644 --- a/src/Helpers/Build.php +++ b/src/Helpers/Build.php @@ -549,7 +549,7 @@ { $rolloutpercentage = isset($this->confProp['rollout']['percentage']) ? (int) $this->confProp['rollout']['percentage'] : 100; if ($rolloutpercentage <= 0 || $rolloutpercentage > 100) { - $rolloutpercentage = 100; + return TRUE; } $rand_number = rand(1, 100); if ($rand_number > $rolloutpercentage) { -- GitLab From 7dbdc5fed5f04a1fd5120421842a56abf822045f Mon Sep 17 00:00:00 2001 From: Ronak Patel Date: Fri, 11 Mar 2022 14:39:56 +0530 Subject: [PATCH 4/6] resolve issue with 0 percentage --- src/Helpers/Build.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Helpers/Build.php b/src/Helpers/Build.php index e873d83..b5fb04b 100644 --- a/src/Helpers/Build.php +++ b/src/Helpers/Build.php @@ -552,7 +552,7 @@ return TRUE; } $rand_number = rand(1, 100); - if ($rand_number > $rolloutpercentage) { + if ($rand_number < $rolloutpercentage) { return FALSE; } return TRUE; -- GitLab From b98d640eed600222ae40ede084972b50feb1eed5 Mon Sep 17 00:00:00 2001 From: Ronak Patel Date: Fri, 11 Mar 2022 14:40:10 +0530 Subject: [PATCH 5/6] resolve issue with 0 percentage --- src/Helpers/Build.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Helpers/Build.php b/src/Helpers/Build.php index b5fb04b..81eabc6 100644 --- a/src/Helpers/Build.php +++ b/src/Helpers/Build.php @@ -552,7 +552,7 @@ return TRUE; } $rand_number = rand(1, 100); - if ($rand_number < $rolloutpercentage) { + if ($rand_number <= $rolloutpercentage) { return FALSE; } return TRUE; -- GitLab From f10626dd5ee420153915485c3b1b0d819500a7c2 Mon Sep 17 00:00:00 2001 From: Ronak Patel Date: Fri, 11 Mar 2022 14:44:17 +0530 Subject: [PATCH 6/6] resolve issue with 0 percentage --- src/Helpers/Build.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Helpers/Build.php b/src/Helpers/Build.php index 81eabc6..e873d83 100644 --- a/src/Helpers/Build.php +++ b/src/Helpers/Build.php @@ -552,7 +552,7 @@ return TRUE; } $rand_number = rand(1, 100); - if ($rand_number <= $rolloutpercentage) { + if ($rand_number > $rolloutpercentage) { return FALSE; } return TRUE; -- GitLab