Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit faa88f9f authored by Amit Mahajan's avatar Amit Mahajan
Browse files

Use SIMRecords for setVoicemailNumber() over RuimRecords. 

RuimRecords does not support voicemail number.

Test: Basic telephony sanity
Bug: 109838253
Change-Id: I04c86853a6c1b27203981f8f3bd5ad457a849ee2
parent a8a81ecf

src/java/com/android/internal/telephony/GsmCdmaPhone.java

+6 −0
Original line number Diff line number Diff line
@@ -1682,7 +1682,13 @@ public class GsmCdmaPhone extends Phone { 
        Message resp;

        mVmNumber = voiceMailNumber;

        resp = obtainMessage(EVENT_SET_VM_NUMBER_DONE, 0, 0, onComplete);



        IccRecords r = mIccRecords.get();



        if (!isPhoneTypeGsm() && mSimRecords != null) {

            r = mSimRecords;

        }



        if (r != null) {

            r.setVoiceMailNumber(alphaTag, mVmNumber, resp);

        }

tests/telephonytests/src/com/android/internal/telephony/GsmCdmaPhoneTest.java

+1 −1
Original line number Diff line number Diff line
@@ -487,7 +487,7 @@ public class GsmCdmaPhoneTest extends TelephonyTest { 
        // voicemail number from sharedPreference

        mPhoneUT.setVoiceMailNumber("alphaTag", voiceMailNumber, null);

        ArgumentCaptor<Message> messageArgumentCaptor = ArgumentCaptor.forClass(Message.class);

        verify(mRuimRecords).setVoiceMailNumber(eq("alphaTag"), eq(voiceMailNumber),

        verify(mSimRecords).setVoiceMailNumber(eq("alphaTag"), eq(voiceMailNumber),

                messageArgumentCaptor.capture());



        Message msg = messageArgumentCaptor.getValue();