Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f7248cd8 authored by Ling Ma's avatar Ling Ma Committed by Android Build Coastguard Worker
Browse files

Enforce privileged phone state for getSubscriptionProperty(GROUP_UUID) 

Bug: 213457638
Test: atest
Change-Id: I8d7cc836402a9a7695c972860d38035c4ec0fa44
Merged-In: I8d7cc836402a9a7695c972860d38035c4ec0fa44
Merged-In: Ie8017c39a495f93603aeb5d1a335fe2fe528cf77
(cherry picked from commit b0e3c5d1)
(cherry picked from commit 7f3dd2af)
Merged-In: I8d7cc836402a9a7695c972860d38035c4ec0fa44
parent f235d517

src/java/com/android/internal/telephony/SubscriptionController.java

+13 −3
Original line number Original line Diff line number Diff line
@@ -2954,10 +2954,20 @@ public class SubscriptionController extends ISub.Stub { 
    @Override

    @Override

    public String getSubscriptionProperty(int subId, String propKey, String callingPackage,

    public String getSubscriptionProperty(int subId, String propKey, String callingPackage,

            String callingFeatureId) {

            String callingFeatureId) {

        if (!TelephonyPermissions.checkCallingOrSelfReadPhoneState(mContext, subId, callingPackage,

        switch (propKey) {

                callingFeatureId, "getSubscriptionProperty")) {

            case SubscriptionManager.GROUP_UUID:

                if (mContext.checkCallingOrSelfPermission(

                        Manifest.permission.READ_PRIVILEGED_PHONE_STATE) != PERMISSION_GRANTED) {

                    EventLog.writeEvent(0x534e4554, "213457638", Binder.getCallingUid());

                    return null;

                }

                break;

            default:

                if (!TelephonyPermissions.checkCallingOrSelfReadPhoneState(mContext, subId,

                        callingPackage, callingFeatureId, "getSubscriptionProperty")) {

                    return null;

                    return null;

                }

                }

        }





        final long identity = Binder.clearCallingIdentity();

        final long identity = Binder.clearCallingIdentity();

        try {

        try {

tests/telephonytests/src/com/android/internal/telephony/SubscriptionControllerTest.java

+31 −0
Original line number Original line Diff line number Diff line
@@ -701,6 +701,37 @@ public class SubscriptionControllerTest extends TelephonyTest { 
        assertNotEquals(groupId, newGroupId);

        assertNotEquals(groupId, newGroupId);

    }

    }





    @Test

    @SmallTest

    public void testGetSubscriptionProperty() throws Exception {

        testInsertSim();

        ContentValues values = new ContentValues();

        values.put(SubscriptionManager.GROUP_UUID, 1);

        mFakeTelephonyProvider.update(SubscriptionManager.CONTENT_URI, values,

                SubscriptionManager.UNIQUE_KEY_SUBSCRIPTION_ID + "=" + 1, null);



        mContextFixture.removeCallingOrSelfPermission(ContextFixture.PERMISSION_ENABLE_ALL);

        mContextFixture.addCallingOrSelfPermission(Manifest.permission.READ_PHONE_STATE);



        // should succeed with read phone state permission

        String prop = mSubscriptionControllerUT.getSubscriptionProperty(1,

                SubscriptionManager.CB_EXTREME_THREAT_ALERT, mContext.getOpPackageName(),

                mContext.getAttributionTag());



        assertNotEquals(null, prop);



        // group UUID requires privileged phone state permission

        prop = mSubscriptionControllerUT.getSubscriptionProperty(1, SubscriptionManager.GROUP_UUID,

                    mContext.getOpPackageName(), mContext.getAttributionTag());

        assertEquals(null, prop);



        // group UUID should succeed once privileged phone state permission is granted

        mContextFixture.addCallingOrSelfPermission(Manifest.permission.READ_PRIVILEGED_PHONE_STATE);

        prop = mSubscriptionControllerUT.getSubscriptionProperty(1, SubscriptionManager.GROUP_UUID,

                mContext.getOpPackageName(), mContext.getAttributionTag());

        assertNotEquals(null, prop);

    }



    @Test

    @Test

    @SmallTest

    @SmallTest

    public void testCreateSubscriptionGroupWithCarrierPrivilegePermission() throws Exception {

    public void testCreateSubscriptionGroupWithCarrierPrivilegePermission() throws Exception {