Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c5c52a39 authored by Amit Mahajan's avatar Amit Mahajan
Browse files

Fix setCdmaBroadcastConfig in RIL.java to include all categories. 

Also disable some flaky tests.

Test: manual
Bug: 38109424
Change-Id: I15a26a8f5134e34cc00e57161faca5924ab82a80
parent 9c3c297d

src/java/com/android/internal/telephony/RIL.java

+17 −16
Original line number Original line Diff line number Diff line
@@ -2712,26 +2712,27 @@ public final class RIL extends BaseCommands implements CommandsInterface { 
            RILRequest rr = obtainRequest(RIL_REQUEST_CDMA_SET_BROADCAST_CONFIG, result,

            RILRequest rr = obtainRequest(RIL_REQUEST_CDMA_SET_BROADCAST_CONFIG, result,

                    mRILDefaultWorkSource);

                    mRILDefaultWorkSource);





            if (RILJ_LOGD) {

                riljLog(rr.serialString() + "> " + requestToString(rr.mRequest)

                        + " with " + configs.length + " configs : ");

                for (int i = 0; i < configs.length; i++) {

                    riljLog(configs[i].toString());

                }

            }



            ArrayList<CdmaBroadcastSmsConfigInfo> halConfigs = new ArrayList<>();

            ArrayList<CdmaBroadcastSmsConfigInfo> halConfigs = new ArrayList<>();





            int numOfConfig = configs.length;

            for (CdmaSmsBroadcastConfigInfo config: configs) {

            CdmaBroadcastSmsConfigInfo info;

                for (int i = config.getFromServiceCategory();



                        i <= config.getToServiceCategory();

            for (int i = 0; i < numOfConfig; i++) {

                        i++) {

                info = new CdmaBroadcastSmsConfigInfo();

                    CdmaBroadcastSmsConfigInfo info = new CdmaBroadcastSmsConfigInfo();

                info.serviceCategory = configs[i].getFromServiceCategory();

                    info.serviceCategory = i;

                info.language = configs[i].getLanguage();

                    info.language = config.getLanguage();

                info.selected = configs[i].isSelected();

                    info.selected = config.isSelected();

                    halConfigs.add(info);

                    halConfigs.add(info);

                }

                }

            }



            if (RILJ_LOGD) {

                riljLog(rr.serialString() + "> " + requestToString(rr.mRequest)

                        + " with " + halConfigs.size() + " configs : ");

                for (CdmaBroadcastSmsConfigInfo config : halConfigs) {

                    riljLog(config.toString());

                }

            }





            try {

            try {

                radioProxy.setCdmaBroadcastConfig(rr.mSerial, halConfigs);

                radioProxy.setCdmaBroadcastConfig(rr.mSerial, halConfigs);

tests/telephonytests/src/com/android/internal/telephony/GsmCdmaCallTrackerTest.java

+5 −0
Original line number Original line Diff line number Diff line
@@ -132,6 +132,8 @@ public class GsmCdmaCallTrackerTest extends TelephonyTest { 
        assertEquals(GsmCdmaCall.State.IDLE, mCTUT.mBackgroundCall.getState());

        assertEquals(GsmCdmaCall.State.IDLE, mCTUT.mBackgroundCall.getState());

    }

    }





    @FlakyTest

    @Ignore

    @Test

    @Test

    @MediumTest

    @MediumTest

    public void testMOCallHangup() {

    public void testMOCallHangup() {
@@ -155,6 +157,7 @@ public class GsmCdmaCallTrackerTest extends TelephonyTest { 
    }

    }





    @FlakyTest

    @FlakyTest

    @Ignore

    @Test

    @Test

    @MediumTest

    @MediumTest

    public void testMOCallDialPickUpHangup() {

    public void testMOCallDialPickUpHangup() {
@@ -355,6 +358,8 @@ public class GsmCdmaCallTrackerTest extends TelephonyTest { 




    }

    }





    @FlakyTest

    @Ignore

    @Test @SmallTest

    @Test @SmallTest

    public void testVoiceCallEndedListener(){

    public void testVoiceCallEndedListener(){

        logd("register for voice call ended event");

        logd("register for voice call ended event");