Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 051dd681 authored by Hakjun Choi's avatar Hakjun Choi
Browse files

Add mock class to avoid Null Point Exception 

Null point exception happend when DatagramDispatcherTest/ReceiverTest were called
ControllerMetricsStats class does not exist for unit test because it is created from SatelliteController

Bug: 278323102
Test: atest DatagramDispatcherTest DatagramReceiverTest
Change-Id: I91fb0fc786882fbd827d0b16f0e78bba8e3fae5c
parent cbd03b17

tests/telephonytests/src/com/android/internal/telephony/satellite/DatagramDispatcherTest.java

+4 −0
Original line number Diff line number Diff line
@@ -37,6 +37,7 @@ import android.testing.TestableLooper; 
import com.android.internal.telephony.Phone;

import com.android.internal.telephony.PhoneFactory;

import com.android.internal.telephony.TelephonyTest;

import com.android.internal.telephony.satellite.metrics.ControllerMetricsStats;



import org.junit.After;

import org.junit.Before;
@@ -61,6 +62,7 @@ public class DatagramDispatcherTest extends TelephonyTest { 


    @Mock private DatagramController mMockDatagramController;

    @Mock private SatelliteModemInterface mMockSatelliteModemInterface;

    @Mock private ControllerMetricsStats mMockControllerMetricsStats;



    /** Variables required to send datagram in the unit tests. */

    LinkedBlockingQueue<Integer> mResultListener;
@@ -77,6 +79,8 @@ public class DatagramDispatcherTest extends TelephonyTest { 
                mMockDatagramController);

        replaceInstance(SatelliteModemInterface.class, "sInstance", null,

                mMockSatelliteModemInterface);

        replaceInstance(ControllerMetricsStats.class, "sInstance", null,

                mMockControllerMetricsStats);



        mDatagramDispatcherUT = DatagramDispatcher.make(mContext, Looper.myLooper(),

                mMockDatagramController);

tests/telephonytests/src/com/android/internal/telephony/satellite/DatagramReceiverTest.java

+4 −0
Original line number Diff line number Diff line
@@ -39,6 +39,7 @@ import android.util.Pair; 
import com.android.internal.telephony.Phone;

import com.android.internal.telephony.PhoneFactory;

import com.android.internal.telephony.TelephonyTest;

import com.android.internal.telephony.satellite.metrics.ControllerMetricsStats;



import org.junit.After;

import org.junit.Before;
@@ -62,6 +63,7 @@ public class DatagramReceiverTest extends TelephonyTest { 


    @Mock private DatagramController mMockDatagramController;

    @Mock private SatelliteModemInterface mMockSatelliteModemInterface;

    @Mock private ControllerMetricsStats mMockControllerMetricsStats;





    /** Variables required to receive datagrams in the unit tests. */
@@ -88,6 +90,8 @@ public class DatagramReceiverTest extends TelephonyTest { 
                mMockDatagramController);

        replaceInstance(SatelliteModemInterface.class, "sInstance", null,

                mMockSatelliteModemInterface);

        replaceInstance(ControllerMetricsStats.class, "sInstance", null,

                mMockControllerMetricsStats);



        mDatagramReceiverUT = DatagramReceiver.make(mContext, Looper.myLooper(),

                mMockDatagramController);