Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f5883db7 authored by Treehugger Robot's avatar Treehugger Robot Committed by Gerrit Code Review
Browse files

Merge "libbinder: Add log when FDs aren't supported in RpcSession" into main

parents 5a1c5a12 f4c9b48c

libs/binder/Parcel.cpp

+5 −0
Original line number Original line Diff line number Diff line
@@ -1585,10 +1585,15 @@ status_t Parcel::writeFileDescriptor(int fd, bool takeOwnership) { 
            fdVariant = borrowed_fd(fd);

            fdVariant = borrowed_fd(fd);

        }

        }

        if (!mAllowFds) {

        if (!mAllowFds) {

            ALOGE("FDs are not allowed in this parcel. Both the service and the client must set "

                  "the FileDescriptorTransportMode and agree on the support.");

            return FDS_NOT_ALLOWED;

            return FDS_NOT_ALLOWED;

        }

        }

        switch (rpcFields->mSession->getFileDescriptorTransportMode()) {

        switch (rpcFields->mSession->getFileDescriptorTransportMode()) {

            case RpcSession::FileDescriptorTransportMode::NONE: {

            case RpcSession::FileDescriptorTransportMode::NONE: {

                ALOGE("FDs are not allowed in this RpcSession. Both the service and the client "

                      "must set "

                      "the FileDescriptorTransportMode and agree on the support.");

                return FDS_NOT_ALLOWED;

                return FDS_NOT_ALLOWED;

            }

            }

            case RpcSession::FileDescriptorTransportMode::UNIX:

            case RpcSession::FileDescriptorTransportMode::UNIX: