Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit eac7055b authored by Makoto Onuki's avatar Makoto Onuki
Browse files

DomainNameValiator: Remove workaround 

Remove the workaround introduced in CL 68137-p9.
Validation should fail when a certification can't be parsed.

Bug: 2369689
parent 73b2c3c5

common/java/com/android/common/DomainNameValidator.java

+6 −15
Original line number Diff line number Diff line
@@ -166,22 +166,13 @@ public class DomainNameValidator { 
                }

            }

        } catch (CertificateParsingException e) {

            // TODO figure out if this comment is still true

            //      i.e. In what condition do we this exception with a valid certificate?



            // one way we can get here is if an alternative name starts with

            // '*' character, which is contrary to one interpretation of the

            // spec (a valid DNS name must start with a letter); there is no

            // good way around this, and in order to be compatible we proceed

            // to check the common name (ie, ignore alternative names)

            if (LOG_ENABLED) {

            String errorMessage = e.getMessage();

            if (errorMessage == null) {

                errorMessage = "failed to parse certificate";

            }



                Log.v(TAG, "DomainNameValidator.matchDns(): " + errorMessage);

            }

            Log.w(TAG, "DomainNameValidator.matchDns(): " + errorMessage);

            return false;

        }



        if (!hasDns) {