Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d6b2b05f authored by Prabir Pradhan's avatar Prabir Pradhan
Browse files

InputTracer: Create tracker for tracing synthetic events 

Allow the creation of a trace tracker for a synthetic event that does
not stem from an inbound input event. This is used for any dispatching
cycle that has a non-input event root, such as ANR timers, window
removals, API interactions (e.g. pilfer pointers), etc.

Any key or motion events generated for this synthetic event should be
traced as a derived event. We achieve this by passing the trace tracker
through the dispatching pipeline, and tracing all of the synthesized
events for that root using the same tracker.

Since all synthetic events can now be traced, we can now enforce that
all dispatched events have been previously traced as either an inbound
or derived event. This makes the event cookie non-nullable.

Bug: 210460522
Test: atest inputflinger_tests
Change-Id: I3417aee300edc251e2f7cb76c1f719502a5f5b8b
parent e7701644

services/inputflinger/dispatcher/CancelationOptions.h

+9 −1
Original line number Diff line number Diff line
@@ -16,6 +16,8 @@ 


#pragma once



#include "trace/EventTrackerInterface.h"



#include <input/Input.h>

#include <bitset>

#include <optional>
@@ -51,7 +53,13 @@ struct CancelationOptions { 
    // The specific pointers to cancel, or nullopt to cancel all pointer events

    std::optional<std::bitset<MAX_POINTER_ID + 1>> pointerIds = std::nullopt;



    CancelationOptions(Mode mode, const char* reason) : mode(mode), reason(reason) {}

    const std::unique_ptr<trace::EventTrackerInterface>& traceTracker;



    explicit CancelationOptions(Mode mode, const char* reason,

                                const std::unique_ptr<trace::EventTrackerInterface>& traceTracker)

          : mode(mode), reason(reason), traceTracker(traceTracker) {}

    CancelationOptions(const CancelationOptions&) = delete;

    CancelationOptions operator=(const CancelationOptions&) = delete;

};



} // namespace inputdispatcher

services/inputflinger/dispatcher/InputDispatcher.cpp

+103 −32

File changed.

Preview size limit exceeded, changes collapsed.

services/inputflinger/dispatcher/InputDispatcher.h

+6 −2
Original line number Diff line number Diff line
@@ -628,7 +628,8 @@ private: 


    void synthesizePointerDownEventsForConnectionLocked(

            const nsecs_t downTime, const std::shared_ptr<Connection>& connection,

            ftl::Flags<InputTarget::Flags> targetFlags) REQUIRES(mLock);

            ftl::Flags<InputTarget::Flags> targetFlags,

            const std::unique_ptr<trace::EventTrackerInterface>& traceTracker) REQUIRES(mLock);



    // Splitting motion events across windows. When splitting motion event for a target,

    // splitDownTime refers to the time of first 'down' event on that particular target
@@ -657,6 +658,7 @@ private: 
    void doInterceptKeyBeforeDispatchingCommand(const sp<IBinder>& focusedWindowToken,

                                                const KeyEntry& entry) REQUIRES(mLock);

    void onFocusChangedLocked(const FocusResolver::FocusChanges& changes,

                              const std::unique_ptr<trace::EventTrackerInterface>& traceTracker,

                              const sp<gui::WindowInfoHandle> removedFocusedWindowHandle = nullptr)

            REQUIRES(mLock);

    void sendFocusChangedCommandLocked(const sp<IBinder>& oldToken, const sp<IBinder>& newToken)
@@ -704,7 +706,9 @@ private: 
                                const sp<android::gui::WindowInfoHandle> fromWindowHandle,

                                const sp<android::gui::WindowInfoHandle> toWindowHandle,

                                TouchState& state, int32_t deviceId,

                                const std::vector<PointerProperties>& pointers) REQUIRES(mLock);

                                const std::vector<PointerProperties>& pointers,

                                const std::unique_ptr<trace::EventTrackerInterface>& traceTracker)

            REQUIRES(mLock);



    sp<android::gui::WindowInfoHandle> findWallpaperWindowBelow(

            const sp<android::gui::WindowInfoHandle>& windowHandle) const REQUIRES(mLock);

services/inputflinger/dispatcher/trace/InputTracer.cpp

+19 −4
Original line number Diff line number Diff line
@@ -65,6 +65,10 @@ void writeEventToBackend(const TracedEvent& event, InputTracingBackendInterface& 
               event);

}



inline auto getId(const trace::TracedEvent& v) {

    return std::visit([](const auto& event) { return event.id; }, v);

}



} // namespace



// --- InputTracer ---
@@ -89,6 +93,12 @@ std::unique_ptr<EventTrackerInterface> InputTracer::traceInboundEvent(const Even 
    return std::make_unique<EventTrackerImpl>(std::move(eventState), /*isDerived=*/false);

}



std::unique_ptr<EventTrackerInterface> InputTracer::createTrackerForSyntheticEvent() {

    // Create a new EventState to track events derived from this tracker.

    return std::make_unique<EventTrackerImpl>(std::make_shared<EventState>(*this),

                                              /*isDerived=*/false);

}



void InputTracer::dispatchToTargetHint(const EventTrackerInterface& cookie,

                                       const InputTarget& target) {

    if (isDerivedCookie(cookie)) {
@@ -140,7 +150,8 @@ std::unique_ptr<EventTrackerInterface> InputTracer::traceDerivedEvent( 
}



void InputTracer::traceEventDispatch(const DispatchEntry& dispatchEntry,

                                     const EventTrackerInterface* cookie) {

                                     const EventTrackerInterface& cookie) {

    auto& eventState = getState(cookie);

    const EventEntry& entry = *dispatchEntry.eventEntry;

    // TODO(b/328618922): Remove resolved key repeats after making repeatCount non-mutable.

    // The KeyEntry's repeatCount is mutable and can be modified after an event is initially traced,
@@ -159,9 +170,13 @@ void InputTracer::traceEventDispatch(const DispatchEntry& dispatchEntry, 
        LOG(FATAL) << "Cannot trace EventEntry of type: " << ftl::enum_string(entry.type);

    }



    if (!cookie) {

        // This event was not tracked as an inbound event, so trace it now.

        writeEventToBackend(traced, *mBackend);

    auto tracedEventIt =

            std::find_if(eventState->events.begin(), eventState->events.end(),

                         [&traced](const auto& event) { return getId(traced) == getId(event); });

    if (tracedEventIt == eventState->events.end()) {

        LOG(FATAL)

                << __func__

                << ": Failed to find a previously traced event that matches the dispatched event";

    }



    // The vsyncId only has meaning if the event is targeting a window.

services/inputflinger/dispatcher/trace/InputTracer.h

+2 −1
Original line number Diff line number Diff line
@@ -42,11 +42,12 @@ public: 
    InputTracer& operator=(const InputTracer&) = delete;



    std::unique_ptr<EventTrackerInterface> traceInboundEvent(const EventEntry&) override;

    std::unique_ptr<EventTrackerInterface> createTrackerForSyntheticEvent() override;

    void dispatchToTargetHint(const EventTrackerInterface&, const InputTarget&) override;

    void eventProcessingComplete(const EventTrackerInterface&) override;

    std::unique_ptr<EventTrackerInterface> traceDerivedEvent(const EventEntry&,

                                                             const EventTrackerInterface&) override;

    void traceEventDispatch(const DispatchEntry&, const EventTrackerInterface*) override;

    void traceEventDispatch(const DispatchEntry&, const EventTrackerInterface&) override;



private:

    std::unique_ptr<InputTracingBackendInterface> mBackend;