Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c65de597 authored by Michael Wachenschwanz's avatar Michael Wachenschwanz
Browse files

Logging for catching memory issue in Parcel 



Added a check to catch a bug that is suspected to lead to a segfault
during GC. Actual fix for the bug is commented and will be checked in
once the flow that is hitting the bug is uncoverered

Bug: 37298089
Test: manual

Change-Id: I68dea02566a9e9375e3a09d4cc19e39379d84747
Signed-off-by: default avatarMichael Wachenschwanz <mwachens@google.com>
parent 8d320dfc

libs/binder/Parcel.cpp

+9 −1
Original line number Diff line number Diff line
@@ -2540,8 +2540,16 @@ status_t Parcel::continueWrite(size_t desired) 
            objectsSize = 0;

        } else {

            while (objectsSize > 0) {

                if (mObjects[objectsSize-1] < desired)

                if (mObjects[objectsSize-1] < desired) {

                    // Check for an object being sliced

                    if (desired < mObjects[objectsSize-1] + sizeof(flat_binder_object)) {

                        ALOGE("Attempt to shrink Parcel would slice an objects allocated memory");

                        return UNKNOWN_ERROR + 0xBADF10;

                    }

                    break;

                }

                // STOPSHIP: Above code to be replaced with following commented code:

                // if (mObjects[objectsSize-1] + sizeof(flat_binder_object) <= desired) break;

                objectsSize--;

            }

        }