Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b8ba6e9c authored by Todd Frederick's avatar Todd Frederick Committed by Gerrit Code Review
Browse files

Merge "dumpstate: Close API FDs on exec"

parents 24350bb0 621533f8

cmds/dumpstate/dumpstate.cpp

+2 −2
Original line number Diff line number Diff line
@@ -2733,8 +2733,8 @@ void Dumpstate::DumpOptions::Initialize(BugreportMode bugreport_mode, 
                                        const android::base::unique_fd& screenshot_fd_in,

                                        bool is_screenshot_requested) {

    // Duplicate the fds because the passed in fds don't outlive the binder transaction.

    bugreport_fd.reset(dup(bugreport_fd_in.get()));

    screenshot_fd.reset(dup(screenshot_fd_in.get()));

    bugreport_fd.reset(fcntl(bugreport_fd_in.get(), F_DUPFD_CLOEXEC, 0));

    screenshot_fd.reset(fcntl(screenshot_fd_in.get(), F_DUPFD_CLOEXEC, 0));



    SetOptionsFromMode(bugreport_mode, this, is_screenshot_requested);

}