Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b6a1e7eb authored by Steven Moreland's avatar Steven Moreland
Browse files

libbinder: remove RpcState deadlock debug logs 

'dump' internally takes a lock, and there were two calls to it here
which would actually deadlock. Simply removing them to move fuzzer
forward.

Bug: 182938024
Test: fuzzer
Change-Id: Ic07193955f0794fd1fc11d7e89c65b469a43323c
parent e8393349

libs/binder/RpcState.cpp

+0 −2
Original line number Diff line number Diff line
@@ -511,7 +511,6 @@ status_t RpcState::processTransactInternal(const base::unique_fd& fd, const sp<R 
        auto it = mNodeForAddress.find(addr);

        if (it == mNodeForAddress.end()) {

            ALOGE("Unknown binder address %s.", addr.toString().c_str());

            dump();

            replyStatus = BAD_VALUE;

        } else {

            target = it->second.binder.promote();
@@ -707,7 +706,6 @@ status_t RpcState::processDecStrong(const base::unique_fd& fd, const RpcWireHead 
    auto it = mNodeForAddress.find(addr);

    if (it == mNodeForAddress.end()) {

        ALOGE("Unknown binder address %s for dec strong.", addr.toString().c_str());

        dump();

        return OK;

    }