Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit aa8fdc0a authored by Steven Moreland's avatar Steven Moreland Committed by Automerger Merge Worker
Browse files

Merge "Revert "libbinder_ndk: toString never goes to empty strings."" am: d513a26a 

Original change: https://android-review.googlesource.com/c/platform/frameworks/native/+/2321904



Change-Id: I4c67dcbbad2b1480f74fab9b7237cc2af985056f
Signed-off-by: default avatarAutomerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
parents 42aa8170 d513a26a

libs/binder/ndk/include_cpp/android/binder_to_string.h

+3 −5
Original line number Diff line number Diff line
@@ -160,7 +160,7 @@ class ToEmptyString { 
template <typename _T>

std::string ToString(const _T& t) {

    if constexpr (details::ToEmptyString<_T>::value) {

        return "<unimplemented>";

        return "";

    } else if constexpr (std::is_same_v<bool, _T>) {

        return t ? "true" : "false";

    } else if constexpr (std::is_same_v<char16_t, _T>) {
@@ -176,11 +176,9 @@ std::string ToString(const _T& t) { 
        return t;

#ifdef HAS_NDK_INTERFACE

    } else if constexpr (std::is_same_v<::ndk::SpAIBinder, _T>) {

        std::stringstream ss;

        ss << "binder:" << std::hex << t.get();

        return ss.str();

        return (t.get() == nullptr) ? "(null)" : "";

    } else if constexpr (std::is_same_v<::ndk::ScopedFileDescriptor, _T>) {

        return "fd:" + std::to_string(t.get());

        return (t.get() == -1) ? "(null)" : "";

#endif

#ifdef HAS_STRING16

    } else if constexpr (std::is_same_v<String16, _T>) {