Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content
Commit a0d32afb authored by Egor Pasko's avatar Egor Pasko
Browse files

Expose InputConsumer::probablyHasInput

Introduce InputConsumer::probablyHasInput() to check for availability of
input events that have not been consumed yet. It performs a poll on the
underlying file descriptor.

The return value is precise (modulo rare syscall interruptions), but
clients should handle it as a performance hint. This hint would allow to
prioritize input-related work, but only when input events are *likely*
pending.

Usage constraints for a future/possible API in the Android Framework:

0. This is experimental. The usefulness of the hint has not been
   broadly proven, and the functionality can be removed soon if there is
   no robust data to support the usefulness.

1. The high-level API visible to apps would be effectively opt-in: does
   not create any state if not used.

2. An app could use this hint to yield from longer tasks on the UI
   thread (which it is not supposed to create in the first place). This
   is a very niche workaround for Chrome's complexity.

3. Using the Input Hint in WebView should probably be disabled: WebView
   has less control over the embedding app than Chrome, and less
   knowledge when to prioritize for input handling.

4. There is a good question whether probablyHasInput() should guarantee
   to return true only when input is queued. While it is good to return
   precise results, clients should only use this API as an optimization
   hint without sacrificing correctness. Due to the growing complexity
   of input handling on Android, it is not too hard to imagine that in
   some not-too-distant future input would get filtered by the Framework
   on the application side, potentially skipping the contents from the
   ready-to-read file descriptor or an accumulated InputConsumer batch.

Bug: b/314973388
Test: atest 'InputChannelTest#ProbablyHasInput'
Test: atest InputPublisherAndConsumerTest
Change-Id: I9681a9ddd0249e3bfd5285c6570dee7a9f5de951
parent 8e185db6
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment