Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a03e1302 authored by Vishnu Nair's avatar Vishnu Nair
Browse files

Remove unsafe cast in Client::createWithSurfaceParent 

Logs were initially added to debug an issue which has since been fixed.

Bug: b/150226994, b/134888387
Test: POC from file does not crash on device with AddressSanitizer
Change-Id: I582b1737026bd1dae62539a88e86dd2fd8edb539
parent 4271f564

services/surfaceflinger/Client.cpp

+0 −5
Original line number Diff line number Diff line
@@ -88,11 +88,6 @@ status_t Client::createWithSurfaceParent(const String8& name, uint32_t w, uint32 
                                         sp<IGraphicBufferProducer>* gbp) {

    if (mFlinger->authenticateSurfaceTexture(parent) == false) {

        ALOGE("failed to authenticate surface texture");

        // The extra parent layer check below before returning is to help with debugging

        // b/134888387. Once the bug is fixed the check can be deleted.

        if ((static_cast<MonitoredProducer*>(parent.get()))->getLayer() == nullptr) {

            ALOGE("failed to find parent layer");

        }

        return BAD_VALUE;

    }