Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8c1fdfb5 authored by Steven Moreland's avatar Steven Moreland Committed by android-build-team Robot
Browse files

libbinder: Status: check dataPosition sets. 

Bug: 132650049
Test: fuzzer
Change-Id: Id230eae4316a444bc82b416b2049d5a5f589f89a
Merged-In: Id230eae4316a444bc82b416b2049d5a5f589f89a
(cherry picked from commit 509e0e02)
parent 031131ef

libs/binder/Status.cpp

+29 −2
Original line number Original line Diff line number Diff line
@@ -76,13 +76,23 @@ status_t Status::readFromParcel(const Parcel& parcel) { 
    // Skip over fat response headers.  Not used (or propagated) in native code.

    // Skip over fat response headers.  Not used (or propagated) in native code.

    if (mException == EX_HAS_REPLY_HEADER) {

    if (mException == EX_HAS_REPLY_HEADER) {

        // Note that the header size includes the 4 byte size field.

        // Note that the header size includes the 4 byte size field.

        const int32_t header_start = parcel.dataPosition();

        const size_t header_start = parcel.dataPosition();

        // Get available size before reading more

        const size_t header_avail = parcel.dataAvail();



        int32_t header_size;

        int32_t header_size;

        status = parcel.readInt32(&header_size);

        status = parcel.readInt32(&header_size);

        if (status != OK) {

        if (status != OK) {

            setFromStatusT(status);

            setFromStatusT(status);

            return status;

            return status;

        }

        }



        if (header_size < 0 || static_cast<size_t>(header_size) > header_avail) {

            android_errorWriteLog(0x534e4554, "132650049");

            setFromStatusT(UNKNOWN_ERROR);

            return UNKNOWN_ERROR;

        }



        parcel.setDataPosition(header_start + header_size);

        parcel.setDataPosition(header_start + header_size);

        // And fat response headers are currently only used when there are no

        // And fat response headers are currently only used when there are no

        // exceptions, so act like there was no error.

        // exceptions, so act like there was no error.
@@ -109,19 +119,36 @@ status_t Status::readFromParcel(const Parcel& parcel) { 
        setFromStatusT(status);

        setFromStatusT(status);

        return status;

        return status;

    }

    }

    if (remote_stack_trace_header_size < 0 ||

        static_cast<size_t>(remote_stack_trace_header_size) > parcel.dataAvail()) {



        android_errorWriteLog(0x534e4554, "132650049");

        setFromStatusT(UNKNOWN_ERROR);

        return UNKNOWN_ERROR;

    }

    parcel.setDataPosition(parcel.dataPosition() + remote_stack_trace_header_size);

    parcel.setDataPosition(parcel.dataPosition() + remote_stack_trace_header_size);





    if (mException == EX_SERVICE_SPECIFIC) {

    if (mException == EX_SERVICE_SPECIFIC) {

        status = parcel.readInt32(&mErrorCode);

        status = parcel.readInt32(&mErrorCode);

    } else if (mException == EX_PARCELABLE) {

    } else if (mException == EX_PARCELABLE) {

        // Skip over the blob of Parcelable data

        // Skip over the blob of Parcelable data

        const int32_t header_start = parcel.dataPosition();

        const size_t header_start = parcel.dataPosition();

        // Get available size before reading more

        const size_t header_avail = parcel.dataAvail();



        int32_t header_size;

        int32_t header_size;

        status = parcel.readInt32(&header_size);

        status = parcel.readInt32(&header_size);

        if (status != OK) {

        if (status != OK) {

            setFromStatusT(status);

            setFromStatusT(status);

            return status;

            return status;

        }

        }



        if (header_size < 0 || static_cast<size_t>(header_size) > header_avail) {

            android_errorWriteLog(0x534e4554, "132650049");

            setFromStatusT(UNKNOWN_ERROR);

            return UNKNOWN_ERROR;

        }



        parcel.setDataPosition(header_start + header_size);

        parcel.setDataPosition(header_start + header_size);

    }

    }

    if (status != OK) {

    if (status != OK) {