Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8aeb1def authored by Steven Moreland's avatar Steven Moreland
Browse files

libbinder: remove unique_ptr FD APIs. 

There are many deprecated APIs here, and mkate@'s data
indicates they aren't used. Going ahead and trying to
remove one of them to see what happens.

Bug: N/A
Test: N/A
Change-Id: I91b38fbe88a6e4ece3d261f32e93f45de2a6a0fb
parent 38a4ab9f

libs/binder/Parcel.cpp

+0 −8
Original line number Diff line number Diff line
@@ -1314,10 +1314,6 @@ status_t Parcel::writeUniqueFileDescriptorVector(const std::vector<unique_fd>& v 
status_t Parcel::writeUniqueFileDescriptorVector(const std::optional<std::vector<unique_fd>>& val) {

    return writeData(val);

}

status_t Parcel::writeUniqueFileDescriptorVector(

        const std::unique_ptr<std::vector<unique_fd>>& val) {

    return writeData(val);

}



status_t Parcel::writeStrongBinderVector(const std::vector<sp<IBinder>>& val) { return writeData(val); }

status_t Parcel::writeStrongBinderVector(const std::optional<std::vector<sp<IBinder>>>& val) { return writeData(val); }
@@ -1373,10 +1369,6 @@ status_t Parcel::readUtf8VectorFromUtf16Vector(std::vector<std::string>* val) co 
status_t Parcel::readUniqueFileDescriptorVector(std::optional<std::vector<unique_fd>>* val) const {

    return readData(val);

}

status_t Parcel::readUniqueFileDescriptorVector(

        std::unique_ptr<std::vector<unique_fd>>* val) const {

    return readData(val);

}

status_t Parcel::readUniqueFileDescriptorVector(std::vector<unique_fd>* val) const {

    return readData(val);

}

libs/binder/include/binder/Parcel.h

+0 −6
Original line number Diff line number Diff line
@@ -383,9 +383,6 @@ public: 
    LIBBINDER_EXPORTED status_t

    writeUniqueFileDescriptorVector(const std::optional<std::vector<binder::unique_fd>>& val);

    LIBBINDER_EXPORTED status_t

    writeUniqueFileDescriptorVector(const std::unique_ptr<std::vector<binder::unique_fd>>& val)

            __attribute__((deprecated("use std::optional version instead")));

    LIBBINDER_EXPORTED status_t

    writeUniqueFileDescriptorVector(const std::vector<binder::unique_fd>& val);



    // Writes a blob to the parcel.
@@ -626,9 +623,6 @@ public: 
    LIBBINDER_EXPORTED status_t

    readUniqueFileDescriptorVector(std::optional<std::vector<binder::unique_fd>>* val) const;

    LIBBINDER_EXPORTED status_t

    readUniqueFileDescriptorVector(std::unique_ptr<std::vector<binder::unique_fd>>* val) const

            __attribute__((deprecated("use std::optional version instead")));

    LIBBINDER_EXPORTED status_t

    readUniqueFileDescriptorVector(std::vector<binder::unique_fd>* val) const;



    // Reads a blob from the parcel.

libs/binder/tests/parcel_fuzzer/binder.cpp

+0 −2
Original line number Diff line number Diff line
@@ -318,8 +318,6 @@ std::vector<ParcelRead<::android::Parcel>> BINDER_PARCEL_READ_FUNCTIONS { 
    PARCEL_READ_NO_STATUS(int, readParcelFileDescriptor),

    PARCEL_READ_WITH_STATUS(unique_fd, readUniqueFileDescriptor),



    PARCEL_READ_WITH_STATUS(std::unique_ptr<std::vector<unique_fd>>,

            readUniqueFileDescriptorVector),

    PARCEL_READ_WITH_STATUS(std::optional<std::vector<unique_fd>>, readUniqueFileDescriptorVector),

    PARCEL_READ_WITH_STATUS(std::vector<unique_fd>, readUniqueFileDescriptorVector),