Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 74cf613f authored by Steven Moreland's avatar Steven Moreland
Browse files

libbinder: disable implicit unique_fd get 

Considered dangerous, since we will be using more unique_fd here soon.

Bug: N/A
Test: build
Change-Id: I35dcbb889527cdbfd16e7feb9c2611fe3cb11f68
parent 05f351cb

libs/binder/Android.bp

+1 −0
Original line number Diff line number Diff line
@@ -146,6 +146,7 @@ cc_library { 
        "-Wextra",

        "-Werror",

        "-Wzero-as-null-pointer-constant",

        "-DANDROID_BASE_UNIQUE_FD_DISABLE_IMPLICIT_CONVERSION",

    ],

    product_variables: {

        binder32bit: {

libs/binder/include/binder/ParcelFileDescriptor.h

+6 −6
Original line number Diff line number Diff line
@@ -44,22 +44,22 @@ public: 
    android::status_t readFromParcel(const android::Parcel* parcel) override;



    inline bool operator!=(const ParcelFileDescriptor& rhs) const {

        return mFd != rhs.mFd;

        return mFd.get() != rhs.mFd.get();

    }

    inline bool operator<(const ParcelFileDescriptor& rhs) const {

        return mFd < rhs.mFd;

        return mFd.get() < rhs.mFd.get();

    }

    inline bool operator<=(const ParcelFileDescriptor& rhs) const {

        return mFd <= rhs.mFd;

        return mFd.get() <= rhs.mFd.get();

    }

    inline bool operator==(const ParcelFileDescriptor& rhs) const {

        return mFd == rhs.mFd;

        return mFd.get() == rhs.mFd.get();

    }

    inline bool operator>(const ParcelFileDescriptor& rhs) const {

        return mFd > rhs.mFd;

        return mFd.get() > rhs.mFd.get();

    }

    inline bool operator>=(const ParcelFileDescriptor& rhs) const {

        return mFd >= rhs.mFd;

        return mFd.get() >= rhs.mFd.get();

    }

private:

    android::base::unique_fd mFd;