Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 73aa6f88 authored by Steven Moreland's avatar Steven Moreland
Browse files

binderRpcTest: undo ThreadPoolLimit optimization 

This test started flaking when we reduced the time it took.
It should be re-written to avoid needing to sleep so long,
but for now, restoring it so it isn't breaking.

Fixes: 272429574
Test: binderRpcTest
Change-Id: Ieef2d585f6743a9a7ac79101d5f7724cff7936c3
parent 69e22e9e

libs/binder/tests/binderRpcTest.cpp

+6 −2
Original line number Original line Diff line number Diff line
@@ -465,7 +465,9 @@ TEST_P(BinderRpc, ThreadPoolOverSaturated) { 
    constexpr size_t kNumThreads = 10;

    constexpr size_t kNumThreads = 10;

    constexpr size_t kNumCalls = kNumThreads + 3;

    constexpr size_t kNumCalls = kNumThreads + 3;

    auto proc = createRpcTestSocketServerProcess({.numThreads = kNumThreads});

    auto proc = createRpcTestSocketServerProcess({.numThreads = kNumThreads});

    testThreadPoolOverSaturated(proc.rootIface, kNumCalls, 250 /*ms*/);



    // b/272429574 - below 500ms, the test fails

    testThreadPoolOverSaturated(proc.rootIface, kNumCalls, 500 /*ms*/);

}

}





TEST_P(BinderRpc, ThreadPoolLimitOutgoing) {

TEST_P(BinderRpc, ThreadPoolLimitOutgoing) {
@@ -478,7 +480,9 @@ TEST_P(BinderRpc, ThreadPoolLimitOutgoing) { 
    constexpr size_t kNumCalls = kNumOutgoingConnections + 3;

    constexpr size_t kNumCalls = kNumOutgoingConnections + 3;

    auto proc = createRpcTestSocketServerProcess(

    auto proc = createRpcTestSocketServerProcess(

            {.numThreads = kNumThreads, .numOutgoingConnections = kNumOutgoingConnections});

            {.numThreads = kNumThreads, .numOutgoingConnections = kNumOutgoingConnections});

    testThreadPoolOverSaturated(proc.rootIface, kNumCalls, 250 /*ms*/);



    // b/272429574 - below 500ms, the test fails

    testThreadPoolOverSaturated(proc.rootIface, kNumCalls, 500 /*ms*/);

}

}





TEST_P(BinderRpc, ThreadingStressTest) {

TEST_P(BinderRpc, ThreadingStressTest) {