Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6f4d2f54 authored by Vishnu Nair's avatar Vishnu Nair
Browse files

[SurfaceComposerClient] Avoid mSurfaceStats mutex contention 

Previous logic acquired mSurfaceStats mutex and called the listeners
with the mutex held between buffer releases. Instead release all the
buffers before handling surface stats listener callbacks and updating
jank data.

Bug: 294935709
Test: presubmit and perfetto traces
Change-Id: Ie90ccde431059bdcdb6900148c6027d313e7434f
parent 774bcbe5

libs/gui/SurfaceComposerClient.cpp

+2 −0
Original line number Original line Diff line number Diff line
@@ -450,7 +450,9 @@ void TransactionCompletedListener::onTransactionCompleted(ListenerStats listener 
            callbackFunction(transactionStats.latchTime, transactionStats.presentFence,

            callbackFunction(transactionStats.latchTime, transactionStats.presentFence,

                             surfaceControlStats);

                             surfaceControlStats);

        }

        }

    }





    for (const auto& transactionStats : listenerStats.transactionStats) {

        for (const auto& surfaceStats : transactionStats.surfaceStats) {

        for (const auto& surfaceStats : transactionStats.surfaceStats) {

            // The callbackMap contains the SurfaceControl object, which we need to look up the

            // The callbackMap contains the SurfaceControl object, which we need to look up the

            // layerId. Since we don't know which callback contains the SurfaceControl, iterate

            // layerId. Since we don't know which callback contains the SurfaceControl, iterate