Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 68e2ee22 authored by Steven Moreland's avatar Steven Moreland
Browse files

binderRpcTest: remove parallelization test 

This test is much flakier these days, and we test
calls can run in parallel elsewher.

Change-Id: If3ea0aeff03acc59a396964a706099ae080eadaf
Fixes: 365294257
Test: TH
parent 2347908d

libs/binder/tests/binderRpcTest.cpp

+7 −9
Original line number Original line Diff line number Diff line
@@ -499,11 +499,11 @@ static void testThreadPoolOverSaturated(sp<IBinderRpcTest> iface, size_t numCall 




    EXPECT_GE(epochMsAfter, epochMsBefore + 2 * sleepMs);

    EXPECT_GE(epochMsAfter, epochMsBefore + 2 * sleepMs);





    // Potential flake, but make sure calls are handled in parallel. Due

    // b/272429574, b/365294257

    // to past flakes, this only checks that the amount of time taken has

    // This flakes too much to test. Parallelization is tested

    // some parallelism. Other tests such as ThreadPoolGreaterThanEqualRequested

    // in ThreadPoolGreaterThanEqualRequested and other tests.

    // check this more exactly.

    // Test to make sure calls are handled in parallel.

    EXPECT_LE(epochMsAfter, epochMsBefore + (numCalls - 1) * sleepMs);

    // EXPECT_LE(epochMsAfter, epochMsBefore + (numCalls - 1) * sleepMs);

}

}





TEST_P(BinderRpc, ThreadPoolOverSaturated) {

TEST_P(BinderRpc, ThreadPoolOverSaturated) {
@@ -515,8 +515,7 @@ TEST_P(BinderRpc, ThreadPoolOverSaturated) { 
    constexpr size_t kNumCalls = kNumThreads + 3;

    constexpr size_t kNumCalls = kNumThreads + 3;

    auto proc = createRpcTestSocketServerProcess({.numThreads = kNumThreads});

    auto proc = createRpcTestSocketServerProcess({.numThreads = kNumThreads});





    // b/272429574 - below 500ms, the test fails

    testThreadPoolOverSaturated(proc.rootIface, kNumCalls, 200 /*ms*/);

    testThreadPoolOverSaturated(proc.rootIface, kNumCalls, 500 /*ms*/);

}

}





TEST_P(BinderRpc, ThreadPoolLimitOutgoing) {

TEST_P(BinderRpc, ThreadPoolLimitOutgoing) {
@@ -530,8 +529,7 @@ TEST_P(BinderRpc, ThreadPoolLimitOutgoing) { 
    auto proc = createRpcTestSocketServerProcess(

    auto proc = createRpcTestSocketServerProcess(

            {.numThreads = kNumThreads, .numOutgoingConnections = kNumOutgoingConnections});

            {.numThreads = kNumThreads, .numOutgoingConnections = kNumOutgoingConnections});





    // b/272429574 - below 500ms, the test fails

    testThreadPoolOverSaturated(proc.rootIface, kNumCalls, 200 /*ms*/);

    testThreadPoolOverSaturated(proc.rootIface, kNumCalls, 500 /*ms*/);

}

}





TEST_P(BinderRpc, ThreadingStressTest) {

TEST_P(BinderRpc, ThreadingStressTest) {