Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 65794463 authored by matthuang's avatar matthuang Committed by Brian Duddie
Browse files

Do not log permission check failures. 

Bug: 195891798
Test: Check log when launch sensorlogger app.
Change-Id: I06b9eeefe640ab35e762aa59b898a01a6e4f2a64
parent 5d71248e

services/sensorservice/SensorService.cpp

+5 −2
Original line number Diff line number Diff line
@@ -2030,7 +2030,9 @@ bool SensorService::hasPermissionForSensor(const Sensor& sensor) { 
    // Runtime permissions can't use the cache as they may change.

    if (sensor.isRequiredPermissionRuntime()) {

        hasPermission = checkPermission(String16(requiredPermission),

                IPCThreadState::self()->getCallingPid(), IPCThreadState::self()->getCallingUid());

                IPCThreadState::self()->getCallingPid(),

                IPCThreadState::self()->getCallingUid(),

                /*logPermissionFailure=*/ false);

    } else {

        hasPermission = PermissionCache::checkCallingPermission(String16(requiredPermission));

    }
@@ -2211,7 +2213,8 @@ bool SensorService::isRateCappedBasedOnPermission(const String16& opPackageName) 
    int targetSdk = getTargetSdkVersion(opPackageName);

    bool hasSamplingRatePermission = checkPermission(sAccessHighSensorSamplingRatePermission,

            IPCThreadState::self()->getCallingPid(),

            IPCThreadState::self()->getCallingUid());

            IPCThreadState::self()->getCallingUid(),

            /*logPermissionFailure=*/ false);

    if (targetSdk < __ANDROID_API_S__ ||

            (targetSdk >= __ANDROID_API_S__ && hasSamplingRatePermission)) {

        return false;