Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 318853aa authored by Zach Riggle's avatar Zach Riggle
Browse files

Prevent otapreopt_chroot from crashing with no arguments 

Currently, it crashes with a NULL dereference when invoked directly

Fixes: commit 0ba073ce
Change-Id: I8f4c6b986333f27c2e0cc641b684656a213ce131
parent 617968b4

cmds/installd/otapreopt_chroot.cpp

+6 −0
Original line number Diff line number Diff line
@@ -59,6 +59,12 @@ static void CloseDescriptor(const char* descriptor_string) { 
// The file descriptor denoted by status-fd will be closed. The rest of the parameters will

// be passed on to otapreopt in the chroot.

static int otapreopt_chroot(const int argc, char **arg) {

    // Validate arguments

    // We need the command, status channel and target slot, at a minimum.

    if(argc < 3) {

        PLOG(ERROR) << "Not enough arguments.";

        exit(208);

    }

    // Close all file descriptors. They are coming from the caller, we do not want to pass them

    // on across our fork/exec into a different domain.

    // 1) Default descriptors.