Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 276d8dfe authored by Steven Moreland's avatar Steven Moreland
Browse files

binderRpcTest: backtrace on leaked session 

There is a bug we're hitting here where sessions leak, but
it only seems to repro on infra. Adding additional logging
to narrow down the issue.

Bug: 244325464
Test: binderRpcTest
Change-Id: I6586534e23ee884be6aa7a6e25258ae2c07aedd9
parent 00a54e41

libs/binder/tests/binderRpcTest.cpp

+10 −1
Original line number Diff line number Diff line
@@ -85,6 +85,11 @@ static std::string WaitStatusToString(int wstatus) { 
    return base::StringPrintf("unexpected state %d", wstatus);

}



static void debugBacktrace(pid_t pid) {

    std::cerr << "TAKING BACKTRACE FOR PID " << pid << std::endl;

    system((std::string("debuggerd -b ") + std::to_string(pid)).c_str());

}



class Process {

public:

    Process(Process&&) = default;
@@ -125,6 +130,8 @@ public: 
    // Kill the process. Avoid if possible. Shutdown gracefully via an RPC instead.

    void terminate() { kill(mPid, SIGTERM); }



    pid_t getPid() { return mPid; }



private:

    std::function<void(int wstatus)> mCustomExitStatusCheck;

    pid_t mPid = 0;
@@ -173,7 +180,9 @@ struct ProcessSession { 


            wp<RpcSession> weakSession = session;

            session = nullptr;

            EXPECT_EQ(nullptr, weakSession.promote()) << "Leaked session";



            EXPECT_EQ(nullptr, weakSession.promote())

                    << (debugBacktrace(host.getPid()), debugBacktrace(getpid()), "Leaked session");

        }

    }

};