Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 13d90b93 authored by Treehugger Robot's avatar Treehugger Robot Committed by Automerger Merge Worker
Browse files

Merge "libbinder: abort on Parcel::appendFrom in no-kernel mode" am: ec0d68e9 

Original change: https://android-review.googlesource.com/c/platform/frameworks/native/+/2147342



Change-Id: Ib8e989d0c1489aedfa564ba716cb291fc2cdcde4
Signed-off-by: default avatarAutomerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
parents 3708e1c3 ec0d68e9

libs/binder/Parcel.cpp

+5 −2
Original line number Original line Diff line number Diff line
@@ -503,8 +503,8 @@ status_t Parcel::appendFrom(const Parcel* parcel, size_t offset, size_t len) { 




    err = NO_ERROR;

    err = NO_ERROR;





#ifdef BINDER_WITH_KERNEL_IPC

    if (auto* kernelFields = maybeKernelFields()) {

    if (auto* kernelFields = maybeKernelFields()) {

#ifdef BINDER_WITH_KERNEL_IPC

        auto* otherKernelFields = parcel->maybeKernelFields();

        auto* otherKernelFields = parcel->maybeKernelFields();

        LOG_ALWAYS_FATAL_IF(otherKernelFields == nullptr);

        LOG_ALWAYS_FATAL_IF(otherKernelFields == nullptr);
@@ -564,6 +564,10 @@ status_t Parcel::appendFrom(const Parcel* parcel, size_t offset, size_t len) { 
                }

                }

            }

            }

        }

        }

#else

        LOG_ALWAYS_FATAL("Binder kernel driver disabled at build time");

        return INVALID_OPERATION;

#endif // BINDER_WITH_KERNEL_IPC

    } else {

    } else {

        auto* rpcFields = maybeRpcFields();

        auto* rpcFields = maybeRpcFields();

        LOG_ALWAYS_FATAL_IF(rpcFields == nullptr);

        LOG_ALWAYS_FATAL_IF(rpcFields == nullptr);
@@ -622,7 +626,6 @@ status_t Parcel::appendFrom(const Parcel* parcel, size_t offset, size_t len) { 
            }

            }

        }

        }

    }

    }

#endif // BINDER_WITH_KERNEL_IPC





    return err;

    return err;

}

}