Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 12d3983c authored by Tim Van Patten's avatar Tim Van Patten Committed by Gerrit Code Review
Browse files

Merge "Cleanup GraphicsEnv::setAngleInfo()" into main

parents 0ed1176a ca7ced38

libs/graphicsenv/GraphicsEnv.cpp

+4 −4
Original line number Diff line number Diff line
@@ -596,7 +596,7 @@ bool GraphicsEnv::shouldUseAngle() { 
// If path is set to nonempty and shouldUseNativeDriver is true, ANGLE will be used regardless.

void GraphicsEnv::setAngleInfo(const std::string& path, const bool shouldUseNativeDriver,

                               const std::string& packageName,

                               const std::vector<std::string> eglFeatures) {

                               const std::vector<std::string>& eglFeatures) {

    if (mShouldUseAngle) {

        // ANGLE is already set up for this application process, even if the application

        // needs to switch from apk to system or vice versa, the application process must
@@ -606,11 +606,11 @@ void GraphicsEnv::setAngleInfo(const std::string& path, const bool shouldUseNati 
        return;

    }



    mAngleEglFeatures = std::move(eglFeatures);

    mAngleEglFeatures = eglFeatures;

    ALOGV("setting ANGLE path to '%s'", path.c_str());

    mAnglePath = std::move(path);

    mAnglePath = path;

    ALOGV("setting app package name to '%s'", packageName.c_str());

    mPackageName = std::move(packageName);

    mPackageName = packageName;

    if (mAnglePath == "system") {

        mShouldUseSystemAngle = true;

    }

libs/graphicsenv/include/graphicsenv/GraphicsEnv.h

+1 −1
Original line number Diff line number Diff line
@@ -114,7 +114,7 @@ public: 
    // If shouldUseNativeDriver is true, it means native GLES drivers must be used for the process.

    // If path is set to nonempty and shouldUseNativeDriver is true, ANGLE will be used regardless.

    void setAngleInfo(const std::string& path, const bool shouldUseNativeDriver,

                      const std::string& packageName, const std::vector<std::string> eglFeatures);

                      const std::string& packageName, const std::vector<std::string>& eglFeatures);

    // Get the ANGLE driver namespace.

    android_namespace_t* getAngleNamespace();

    // Get the app package name.