Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0a68b461 authored by Chia-I Wu's avatar Chia-I Wu
Browse files

surfaceflinger: fix a nullptr dereference 

When the child layer latched a buffer but the fixed-size parent
layer never did (for reasons such as no buffer queued or buffer got
rejected), we could end up with p->mActiveBuffer being nullptr.

Bug: 62996512
Test: manual (I could never repro anyway)
Change-Id: Id7e4c7037633b8a37039baa6e8a306e55170b894
parent 87cd1151

services/surfaceflinger/Layer.cpp

+1 −1
Original line number Diff line number Diff line
@@ -2694,7 +2694,7 @@ Transform Layer::getTransform() const { 
        // for in the transform. We need to mirror this scaling in child surfaces

        // or we will break the contract where WM can treat child surfaces as

        // pixels in the parent surface.

        if (p->isFixedSize()) {

        if (p->isFixedSize() && p->mActiveBuffer != nullptr) {

            int bufferWidth;

            int bufferHeight;

            if ((p->mCurrentTransform & NATIVE_WINDOW_TRANSFORM_ROT_90) == 0) {