Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c2f87b5e authored by Yixiao Luo's avatar Yixiao Luo
Browse files

Release component on destructor 

Currently Component::release() is only called in Component::OnBinderDied(). In some cases, OnBinderDied() is not triggered, resulting in component not released and potential memory leak.

To avoid this issue, call reset() and release() on destructor to ensure it is released.

Bug: 405001050
Test: verified by AMLogic
Flag: EXEMPT bugfix
Change-Id: Ia6025ba4c0dfb002d3163190727e1d28939b49fb
parent 875e93c5

media/codec2/hal/aidl/Component.cpp

+2 −1
Original line number Diff line number Diff line
@@ -554,7 +554,8 @@ void Component::OnBinderUnlinked(void *cookie) { 
}



Component::~Component() {

    InputBufferManager::unregisterFrameData(mListener);

    this->reset();

    this->release();

    mStore->reportComponentDeath(this);

    if (mDeathRecipient.get()) {

        AIBinder_unlinkToDeath(mListener->asBinder().get(), mDeathRecipient.get(), mDeathContext);