Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b0c8afd3 authored by Android Build Coastguard Worker's avatar Android Build Coastguard Worker
Browse files

Merge cherrypicks of [16622627, 16790556] into security-aosp-rvc-release. 

Change-Id: I3ddf65abf59d6b5cde29f97513536c0b331178fa
parents 6f26167e a0858f53

media/codec2/vndk/C2AllocatorIon.cpp

+22 −15
Original line number Diff line number Diff line
@@ -202,6 +202,7 @@ public: 


        c2_status_t err = mapInternal(mapSize, mapOffset, alignmentBytes, prot, flags, &(map.addr), addr);

        if (map.addr) {

            std::lock_guard<std::mutex> guard(mMutexMappings);

            mMappings.push_back(map);

        }

        return err;
@@ -212,6 +213,8 @@ public: 
            ALOGD("tried to unmap unmapped buffer");

            return C2_NOT_FOUND;

        }

        { // Scope for the lock_guard of mMutexMappings.

            std::lock_guard<std::mutex> guard(mMutexMappings);

            for (auto it = mMappings.begin(); it != mMappings.end(); ++it) {

                if (addr != (uint8_t *)it->addr + it->alignmentBytes ||

                        size + it->alignmentBytes != it->size) {
@@ -226,9 +229,11 @@ public: 
                    *fence = C2Fence(); // not using fences

                }

                (void)mMappings.erase(it);

            ALOGV("successfully unmapped: addr=%p size=%zu fd=%d", addr, size, mHandle.bufferFd());

                ALOGV("successfully unmapped: addr=%p size=%zu fd=%d", addr, size,

                          mHandle.bufferFd());

                return C2_OK;

            }

        }

        ALOGD("unmap failed to find specified map");

        return C2_BAD_VALUE;

    }
@@ -236,6 +241,7 @@ public: 
    virtual ~Impl() {

        if (!mMappings.empty()) {

            ALOGD("Dangling mappings!");

            std::lock_guard<std::mutex> guard(mMutexMappings);

            for (const Mapping &map : mMappings) {

                (void)munmap(map.addr, map.size);

            }
@@ -315,6 +321,7 @@ protected: 
        size_t size;

    };

    std::list<Mapping> mMappings;

    std::mutex mMutexMappings;

};



class C2AllocationIon::ImplV2 : public C2AllocationIon::Impl {

media/libheif/HeifDecoderImpl.cpp

+8 −1
Original line number Diff line number Diff line
@@ -25,6 +25,7 @@ 
#include <binder/IMemory.h>

#include <binder/MemoryDealer.h>

#include <drm/drm_framework_common.h>

#include <log/log.h>

#include <media/mediametadataretriever.h>

#include <media/stagefright/MediaSource.h>

#include <media/stagefright/foundation/ADebug.h>
@@ -421,7 +422,13 @@ bool HeifDecoderImpl::reinit(HeifFrameInfo* frameInfo) { 


        initFrameInfo(&mSequenceInfo, videoFrame);



        mSequenceLength = atoi(mRetriever->extractMetadata(METADATA_KEY_VIDEO_FRAME_COUNT));

        const char* frameCount = mRetriever->extractMetadata(METADATA_KEY_VIDEO_FRAME_COUNT);

        if (frameCount == nullptr) {

            android_errorWriteWithInfoLog(0x534e4554, "215002587", -1, NULL, 0);

            ALOGD("No valid sequence information in metadata");

            return false;

        }

        mSequenceLength = atoi(frameCount);



        if (defaultInfo == nullptr) {

            defaultInfo = &mSequenceInfo;