Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c8dd7078 authored by Guennadi Liakhovetski's avatar Guennadi Liakhovetski Committed by Mauro Carvalho Chehab
Browse files

[media] soc-camera: don't dereference I2C client after it has been removed 



i2c_unregister_device() frees the I2C client, so, dereferencing it
afterwards is a bug, that leads to Oopses.

Signed-off-by: default avatarGuennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 3e31f2b9

drivers/media/video/soc_camera.c

+2 −1
Original line number Diff line number Diff line
@@ -996,10 +996,11 @@ static void soc_camera_free_i2c(struct soc_camera_device *icd) 
{

	struct i2c_client *client =

		to_i2c_client(to_soc_camera_control(icd));

	struct i2c_adapter *adap = client->adapter;

	dev_set_drvdata(&icd->dev, NULL);

	v4l2_device_unregister_subdev(i2c_get_clientdata(client));

	i2c_unregister_device(client);

	i2c_put_adapter(client->adapter);

	i2c_put_adapter(adap);

}

#else

#define soc_camera_init_i2c(icd, icl)	(-ENODEV)