Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a2ab0ce0 authored by Christian Engelmayer's avatar Christian Engelmayer Committed by David Woodhouse
Browse files

jffs2: leaking jffs2_summary in function jffs2_scan_medium 



In case of an error returned by file_dirty() 's' is not freed as the cleanup
path is skipped.

Reported by Coverity.

Signed-off-by: default avatarChristian Engelmayer <christian.engelmayer@frequentis.com>
Signed-off-by: default avatarDavid Woodhouse <David.Woodhouse@intel.com>
parent 272023df

fs/jffs2/scan.c

+2 −2
Original line number Diff line number Diff line
@@ -196,7 +196,7 @@ int jffs2_scan_medium(struct jffs2_sb_info *c) 
				if (c->nextblock) {

					ret = file_dirty(c, c->nextblock);

					if (ret)

						return ret;

						goto out;

					/* deleting summary information of the old nextblock */

					jffs2_sum_reset_collected(c->summary);

				}
@@ -207,7 +207,7 @@ int jffs2_scan_medium(struct jffs2_sb_info *c) 
			} else {

				ret = file_dirty(c, jeb);

				if (ret)

					return ret;

					goto out;

			}

			break;