Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Unverified Commit 57d13523 authored by Brendan McGrath's avatar Brendan McGrath Committed by Harsh Shandilya
Browse files

HID: i2c-hid: Add sleep between POWER ON and RESET 

commit a89af4abdf9b353cdd6f61afc0eaaac403304873 upstream.

Support for the Asus Touchpad was recently added. It turns out this
device can fail initialisation (and become unusable) when the RESET
command is sent too soon after the POWER ON command.

Unfortunately the i2c-hid specification does not specify the need for
a delay between these two commands. But it was discovered the Windows
driver has a 1ms delay.

As a result, this patch modifies the i2c-hid module to add a sleep
inbetween the POWER ON and RESET commands which lasts between 1ms and 5ms.

See https://github.com/vlasenko/hid-asus-dkms/issues/24

 for further
details.

Signed-off-by: default avatarBrendan McGrath <redmcg@redmandi.dyndns.org>
Reviewed-by: default avatarBenjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
Signed-off-by: default avatarWilly Tarreau <w@1wt.eu>
parent 66fe2c3b

drivers/hid/i2c-hid/i2c-hid.c

+9 −0
Original line number Diff line number Diff line
@@ -326,6 +326,15 @@ static int i2c_hid_hwreset(struct i2c_client *client) 
	if (ret)

		return ret;



	/*

	 * The HID over I2C specification states that if a DEVICE needs time

	 * after the PWR_ON request, it should utilise CLOCK stretching.

	 * However, it has been observered that the Windows driver provides a

	 * 1ms sleep between the PWR_ON and RESET requests and that some devices

	 * rely on this.

	 */

	usleep_range(1000, 5000);



	i2c_hid_dbg(ihid, "resetting...\n");



	ret = i2c_hid_command(client, &hid_reset_cmd, NULL, 0);