Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4ce1701d authored by Sasha Levin's avatar Sasha Levin Committed by Zvikomborero Vincent Zvikaramba
Browse files

net: llc: use correct size for sysctl timeout entries 



The timeout entries are sizeof(int) rather than sizeof(long), which
means that when they were getting read we'd also leak kernel memory
to userspace along with the timeout values.

Change-Id: I328d1186720a6f70f555eeeb62c83ee69814868d
Signed-off-by: default avatarSasha Levin <sasha.levin@oracle.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 51e6f45c

net/llc/sysctl_net_llc.c

+4 −4
Original line number Diff line number Diff line
@@ -18,28 +18,28 @@ static struct ctl_table llc2_timeout_table[] = { 
	{

		.procname	= "ack",

		.data		= &sysctl_llc2_ack_timeout,

		.maxlen		= sizeof(long),

		.maxlen		= sizeof(sysctl_llc2_ack_timeout),

		.mode		= 0644,

		.proc_handler   = proc_dointvec_jiffies,

	},

	{

		.procname	= "busy",

		.data		= &sysctl_llc2_busy_timeout,

		.maxlen		= sizeof(long),

		.maxlen		= sizeof(sysctl_llc2_busy_timeout),

		.mode		= 0644,

		.proc_handler   = proc_dointvec_jiffies,

	},

	{

		.procname	= "p",

		.data		= &sysctl_llc2_p_timeout,

		.maxlen		= sizeof(long),

		.maxlen		= sizeof(sysctl_llc2_p_timeout),

		.mode		= 0644,

		.proc_handler   = proc_dointvec_jiffies,

	},

	{

		.procname	= "rej",

		.data		= &sysctl_llc2_rej_timeout,

		.maxlen		= sizeof(long),

		.maxlen		= sizeof(sysctl_llc2_rej_timeout),

		.mode		= 0644,

		.proc_handler   = proc_dointvec_jiffies,

	},