Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e2adbecf authored by Russell King's avatar Russell King
Browse files

PCMCIA: sa1111: jornada720: no need to disable IRQs around sa1111_set_io 



sa1111_set_io() already contains the necessary locking within itself
to safely change the state of a set of GPIOs.  There's no need for
callers to protect this by disabling IRQs themselves.

Acked-by: default avatarDominik Brodowski <linux@dominikbrodowski.net>
Signed-off-by: default avatarRussell King <rmk+kernel@arm.linux.org.uk>
parent 65c77dca

drivers/pcmcia/sa1100_jornada720.c

+1 −6
Original line number Original line Diff line number Diff line
@@ -78,13 +78,8 @@ jornada720_pcmcia_configure_socket(struct soc_pcmcia_socket *skt, const socket_s 
	}

	}





	ret = sa1111_pcmcia_configure_socket(skt, state);

	ret = sa1111_pcmcia_configure_socket(skt, state);

	if (ret == 0) {

	if (ret == 0)

		unsigned long flags;



		local_irq_save(flags);

		sa1111_set_io(s->dev, pa_dwr_mask, pa_dwr_set);

		sa1111_set_io(s->dev, pa_dwr_mask, pa_dwr_set);

		local_irq_restore(flags);

	}





	return ret;

	return ret;

}

}