Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1463fdbc authored by Jeff Dike's avatar Jeff Dike Committed by Linus Torvalds
Browse files

[PATCH] uml: pte_mkread fix 



Fix the fact that pte_mkread set _PAGE_RW instead of _PAGE_USER (the logic is
copied from i386 in most place, so it is really as bad as you're thinking).

Thus currently page tables are more permissive than they should.

Such a change may trigger other latent bugs, so be careful with this.

Signed-off-by: default avatarPaolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
Signed-off-by: default avatarJeff Dike <jdike@addtoit.com>
Cc: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 14251809

include/asm-um/pgtable.h

+1 −1
Original line number Diff line number Diff line
@@ -270,7 +270,7 @@ static inline pte_t pte_wrprotect(pte_t pte) 


static inline pte_t pte_mkread(pte_t pte)

{ 

	pte_set_bits(pte, _PAGE_RW);

	pte_set_bits(pte, _PAGE_USER);

	return(pte_mknewprot(pte)); 

}