Commit fb144adc authored Jan 15, 2009 by Andy Whitcroft Committed by Linus Torvalds Jan 15, 2009

sysrq: add commentary on why we use the console loglevel over using KERN_EMERG



Add an explanitory comment as to why we modify the kernel console loglevel
rather than simply moving sysrq messages to KERN_EMERG level.

Signed-off-by: Andy Whitcroft <apw@canonical.com>
Cc: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 47c33d9c

drivers/char/sysrq.c

+6 −0

Original line number	Diff line number	Diff line
		@@ -473,6 +473,12 @@ void __handle_sysrq(int key, struct tty_struct *tty, int check_mask)
		unsigned long flags;

		spin_lock_irqsave(&sysrq_key_table_lock, flags);
		/*
		* Raise the apparent loglevel to maximum so that the sysrq header
		* is shown to provide the user with positive feedback. We do not
		* simply emit this at KERN_EMERG as that would change message
		* routing in the consumers of /proc/kmsg.
		*/
		orig_log_level = console_loglevel;
		console_loglevel = 7;
		printk(KERN_INFO "SysRq : ");