Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f841a487 authored by David Brownell's avatar David Brownell Committed by Linus Torvalds
Browse files

rtc: remove some NOP open/release methods 



Remove NOP methods from rtc-pl030 and rtc-pl031 drivers;
this is pure wasted code.

Signed-off-by: default avatarDavid Brownell <dbrownell@users.sourceforge.net>
Cc: Alessandro Zummo <a.zummo@towertech.it>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent cb49a5e9

drivers/rtc/rtc-pl030.c

+0 −11
Original line number Diff line number Diff line
@@ -34,15 +34,6 @@ static irqreturn_t pl030_interrupt(int irq, void *dev_id) 
	return IRQ_HANDLED;

}



static int pl030_open(struct device *dev)

{

	return 0;

}



static void pl030_release(struct device *dev)

{

}



static int pl030_ioctl(struct device *dev, unsigned int cmd, unsigned long arg)

{

	return -ENOIOCTLCMD;
@@ -104,8 +95,6 @@ static int pl030_set_time(struct device *dev, struct rtc_time *tm) 
}



static const struct rtc_class_ops pl030_ops = {

	.open		= pl030_open,

	.release	= pl030_release,

	.ioctl		= pl030_ioctl,

	.read_time	= pl030_read_time,

	.set_time	= pl030_set_time,

drivers/rtc/rtc-pl031.c

+0 −14
Original line number Diff line number Diff line
@@ -45,18 +45,6 @@ static irqreturn_t pl031_interrupt(int irq, void *dev_id) 
	return IRQ_HANDLED;

}



static int pl031_open(struct device *dev)

{

	/*

	 * We request IRQ in pl031_probe, so nothing to do here...

	 */

	return 0;

}



static void pl031_release(struct device *dev)

{

}



static int pl031_ioctl(struct device *dev, unsigned int cmd, unsigned long arg)

{

	struct pl031_local *ldata = dev_get_drvdata(dev);
@@ -118,8 +106,6 @@ static int pl031_set_alarm(struct device *dev, struct rtc_wkalrm *alarm) 
}



static const struct rtc_class_ops pl031_ops = {

	.open = pl031_open,

	.release = pl031_release,

	.ioctl = pl031_ioctl,

	.read_time = pl031_read_time,

	.set_time = pl031_set_time,