Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f6767dcf authored by Rafael J. Wysocki's avatar Rafael J. Wysocki Committed by Len Brown
Browse files

ACPI / PM: Drop acpi_bus_get_power() 



There are no more users of acpi_bus_get_power(), so it can be
dropped.  Moreover, it should be dropped, because it modifies
the device->power.state field of an ACPI device without updating
the reference counters of the device's power resources, which is
wrong.

Signed-off-by: default avatarRafael J. Wysocki <rjw@sisk.pl>
Signed-off-by: default avatarLen Brown <len.brown@intel.com>
parent 40b73975

drivers/acpi/bus.c

+0 −19
Original line number Diff line number Diff line
@@ -236,25 +236,6 @@ static int __acpi_bus_get_power(struct acpi_device *device, int *state) 
}





int acpi_bus_get_power(acpi_handle handle, int *state)

{

	struct acpi_device *device;

	int result;



	result = acpi_bus_get_device(handle, &device);

	if (result)

		return result;



	result = __acpi_bus_get_power(device, state);

	if (result)

		return result;



	device->power.state = *state;

	return 0;

}

EXPORT_SYMBOL(acpi_bus_get_power);





static int __acpi_bus_set_power(struct acpi_device *device, int state)

{

	int result = 0;

include/acpi/acpi_bus.h

+0 −1
Original line number Diff line number Diff line
@@ -327,7 +327,6 @@ void acpi_bus_data_handler(acpi_handle handle, void *context); 
acpi_status acpi_bus_get_status_handle(acpi_handle handle,

				       unsigned long long *sta);

int acpi_bus_get_status(struct acpi_device *device);

int acpi_bus_get_power(acpi_handle handle, int *state);

int acpi_bus_set_power(acpi_handle handle, int state);

int acpi_bus_update_power(acpi_handle handle, int *state_p);

bool acpi_bus_power_manageable(acpi_handle handle);