Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f52774d8 authored by Jigarkumar Zala's avatar Jigarkumar Zala Committed by Gerrit - the friendly Code Review server
Browse files

msm: camera: flash: Remove race condition in subdev close 



Subdev close is calling flash_shutdown() to flush req and release
device operation. flash_subdev_close() does the mutex lock already.
Removing same mutex lock opertion from flash_shutdown() function
to remove race condition.

Change-Id: Id2fb7c1b73d4294d1e164df3b44e51455ba15b7f
Signed-off-by: default avatarJigarkumar Zala <jzala@codeaurora.org>
parent 37bdc73f

drivers/media/platform/msm/camera/cam_sensor_module/cam_flash/cam_flash_core.c

+0 −2
Original line number Diff line number Diff line
@@ -1616,9 +1616,7 @@ void cam_flash_shutdown(struct cam_flash_ctrl *fctrl) 


	if ((fctrl->flash_state == CAM_FLASH_STATE_CONFIG) ||

		(fctrl->flash_state == CAM_FLASH_STATE_START)) {

		mutex_lock(&(fctrl->flash_mutex));

		fctrl->func_tbl.flush_req(fctrl, FLUSH_ALL, 0);

		mutex_unlock(&(fctrl->flash_mutex));

		rc = fctrl->func_tbl.power_ops(fctrl, false);

		if (rc)

			CAM_ERR(CAM_FLASH, "Power Down Failed rc: %d",