Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f4fbb3ce authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Mark Brown
Browse files

regulator: s5m8767: Fix carried over ena_gpio assignment 



During registration of regulators if external control for regulator was
set in DTS the ena_gpio and ena_gpio_flags fields of regulator_config
were set to proper values.

However the same regulator_config was used in next iterations of loop so
the ena_gpio fields carried over to next regulators.

The issue was not observed as ena_gpio is supported only for Buck9
regulator which is often the last regulator parsed from DTS.
Be sure to clear ena_gpio config fields before registering the
regulator.

Fixes: ee1e0994 (regulator: s5m8767: Use GPIO for controlling Buck9/eMMC)
Signed-off-by: default avatarKrzysztof Kozlowski <k.kozlowski@samsung.com>
Signed-off-by: default avatarMark Brown <broonie@linaro.org>
parent 5481b348

drivers/regulator/s5m8767.c

+1 −0
Original line number Diff line number Diff line
@@ -964,6 +964,7 @@ static int s5m8767_pmic_probe(struct platform_device *pdev) 
		config.driver_data = s5m8767;

		config.regmap = iodev->regmap_pmic;

		config.of_node = pdata->regulators[i].reg_node;

		config.ena_gpio = config.ena_gpio_flags = 0;

		if (pdata->regulators[i].ext_control_gpio)

			s5m8767_regulator_config_ext_control(s5m8767,

					&pdata->regulators[i], &config);