Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit efbe027e authored by Vaidyanathan Srinivasan's avatar Vaidyanathan Srinivasan Committed by Ingo Molnar
Browse files

sched: idle_balance() does not call load_balance_newidle() 



Impact: fix SD_BALANCE_NEWIDLEand broaden its use

load_balance_newidle() does not get called if SD_BALANCE_NEWIDLE is
set at higher level domain (3-CPU) and not in low level domain (2-MC).

pulled_task is initialised to -1 and checked for non-zero which is
always true if the lowest level sched_domain does not have
SD_BALANCE_NEWIDLE flag set.

Signed-off-by: default avatarVaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>
Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
parent 5436499e

kernel/sched.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -3685,7 +3685,7 @@ load_balance_newidle(int this_cpu, struct rq *this_rq, struct sched_domain *sd, 
static void idle_balance(int this_cpu, struct rq *this_rq)

static void idle_balance(int this_cpu, struct rq *this_rq)

{

{

	struct sched_domain *sd;

	struct sched_domain *sd;

	int pulled_task = -1;

	int pulled_task = 0;

	unsigned long next_balance = jiffies + HZ;

	unsigned long next_balance = jiffies + HZ;

	cpumask_t tmpmask;

	cpumask_t tmpmask;