Commit ea8a50e5 authored Jun 09, 2018 by Al Viro Committed by Greg Kroah-Hartman Jul 25, 2018

cxl_getfile(): fix double-iput() on alloc_file() failures



commit d202797f480c0e5918e7642d6716cdc62b3ab5c9 upstream.

Doing iput() after path_put() is wrong.

Cc: stable@vger.kernel.org
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent b12c7d08

drivers/misc/cxl/api.c

+4 −4

Original line number	Diff line number	Diff line
		@@ -102,15 +102,15 @@ static struct file cxl_getfile(const char name,
		d_instantiate(path.dentry, inode);

		file = alloc_file(&path, OPEN_FMODE(flags), fops);
		if (IS_ERR(file))
		goto err_dput;
		if (IS_ERR(file)) {
		path_put(&path);
		goto err_fs;
		}
		file->f_flags = flags & (O_ACCMODE \| O_NONBLOCK);
		file->private_data = priv;

		return file;

		err_dput:
		path_put(&path);
		err_inode:
		iput(inode);
		err_fs: