Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e950e324 authored by xsang's avatar xsang Committed by Gerrit - the friendly Code Review server
Browse files

asoc: add missing null check for volume control 



Pointer is not checked for null in volume control.
Add missing check.

Change-Id: I511a79422eaeced6240849cbb665a289afdc5984
Signed-off-by: default avatarxsang <xsang@codeaurora.org>
parent b4f1c986

asoc/msm-pcm-loopback-v2.c

+25 −4
Original line number Diff line number Diff line 
/* Copyright (c) 2013-2019, The Linux Foundation. All rights reserved.

/* Copyright (c) 2013-2020, The Linux Foundation. All rights reserved.

 *

 * This program is free software; you can redistribute it and/or modify

 * it under the terms of the GNU General Public License version 2 and
@@ -489,10 +489,21 @@ static int msm_pcm_volume_ctl_put(struct snd_kcontrol *kcontrol, 
{

	int rc = 0;

	struct snd_pcm_volume *vol = kcontrol->private_data;

	struct snd_pcm_substream *substream = vol->pcm->streams[0].substream;

	struct snd_pcm_substream *substream = NULL;

	struct msm_pcm_loopback *prtd;

	int volume = ucontrol->value.integer.value[0];



	if (!vol) {

		pr_err("%s: vol is NULL\n", __func__);

		return -ENODEV;

	}



	if (!vol->pcm) {

		pr_err("%s: vol->pcm is NULL\n", __func__);

		return -ENODEV;

	}



	substream = vol->pcm->streams[0].substream;

	pr_debug("%s: volume : 0x%x\n", __func__, volume);

	if ((!substream) || (!substream->runtime)) {

		pr_err("%s substream or runtime not found\n", __func__);
@@ -518,11 +529,21 @@ static int msm_pcm_volume_ctl_get(struct snd_kcontrol *kcontrol, 
{

	int rc = 0;

	struct snd_pcm_volume *vol = snd_kcontrol_chip(kcontrol);

	struct snd_pcm_substream *substream =

		vol->pcm->streams[SNDRV_PCM_STREAM_PLAYBACK].substream;

	struct snd_pcm_substream *substream = NULL;

	struct msm_pcm_loopback *prtd;



	pr_debug("%s\n", __func__);

	if (!vol) {

		pr_err("%s: vol is NULL\n", __func__);

		return -ENODEV;

	}



	if (!vol->pcm) {

		pr_err("%s: vol->pcm is NULL\n", __func__);

		return -ENODEV;

	}



	substream = vol->pcm->streams[SNDRV_PCM_STREAM_PLAYBACK].substream;

	if ((!substream) || (!substream->runtime)) {

		pr_debug("%s substream or runtime not found\n", __func__);

		rc = -ENODEV;

asoc/msm-pcm-q6-noirq.c

+14 −3
Original line number Diff line number Diff line 
/* Copyright (c) 2016-2019, The Linux Foundation. All rights reserved.

/* Copyright (c) 2016-2020, The Linux Foundation. All rights reserved.

 *

 * This program is free software; you can redistribute it and/or modify

 * it under the terms of the GNU General Public License version 2 and
@@ -749,12 +749,23 @@ static int msm_pcm_volume_ctl_put(struct snd_kcontrol *kcontrol, 
	int rc = 0;

	struct snd_pcm_volume *vol = snd_kcontrol_chip(kcontrol);

	struct msm_plat_data *pdata = NULL;

	struct snd_pcm_substream *substream =

		vol->pcm->streams[SNDRV_PCM_STREAM_PLAYBACK].substream;

	struct snd_pcm_substream *substream = NULL;

	struct snd_soc_pcm_runtime *soc_prtd = NULL;

	struct msm_audio *prtd;

	int volume = ucontrol->value.integer.value[0];



	pr_debug("%s\n", __func__);

	if (!vol) {

		pr_err("%s: vol is NULL\n", __func__);

		return -ENODEV;

	}



	if (!vol->pcm) {

		pr_err("%s: vol->pcm is NULL\n", __func__);

		return -ENODEV;

	}



	substream = vol->pcm->streams[SNDRV_PCM_STREAM_PLAYBACK].substream;

	pr_debug("%s: volume : 0x%x\n", __func__, volume);

	if (!substream) {

		pr_err("%s substream not found\n", __func__);

asoc/msm-pcm-q6-v2.c

+12 −2
Original line number Diff line number Diff line
@@ -1419,14 +1419,24 @@ static int msm_pcm_volume_ctl_put(struct snd_kcontrol *kcontrol, 
{

	int rc = 0;

	struct snd_pcm_volume *vol = snd_kcontrol_chip(kcontrol);

	struct snd_pcm_substream *substream =

		vol->pcm->streams[SNDRV_PCM_STREAM_PLAYBACK].substream;

	struct snd_pcm_substream *substream = NULL;

	struct snd_soc_pcm_runtime *soc_prtd = NULL;

	struct msm_plat_data *pdata = NULL;

	struct msm_audio *prtd;

	int volume = ucontrol->value.integer.value[0];



	pr_debug("%s: volume : 0x%x\n", __func__, volume);

	if (!vol) {

		pr_err("%s: vol is NULL\n", __func__);

		return -ENODEV;

	}



	if (!vol->pcm) {

		pr_err("%s: vol->pcm is NULL\n", __func__);

		return -ENODEV;

	}



	substream = vol->pcm->streams[SNDRV_PCM_STREAM_PLAYBACK].substream;

	if (!substream) {

		pr_err("%s substream not found\n", __func__);

		return -ENODEV;