Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e7cb08e8 authored by Dan Carpenter's avatar Dan Carpenter Committed by Martin K. Petersen
Browse files

scsi: zfcp: spin_lock_irqsave() is not nestable 



We accidentally overwrite the original saved value of "flags" so that we
can't re-enable IRQs at the end of the function.  Presumably this
function is mostly called with IRQs disabled or it would be obvious in
testing.

Fixes: aceeffbb ("zfcp: trace full payload of all SAN records (req,resp,iels)")
Cc: <stable@vger.kernel.org> #2.6.38+
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarSteffen Maier <maier@linux.vnet.ibm.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 03eb6b8d

drivers/s390/scsi/zfcp_dbf.c

+1 −1
Original line number Diff line number Diff line
@@ -384,7 +384,7 @@ void zfcp_dbf_san(char *tag, struct zfcp_dbf *dbf, 
	/* if (len > rec_len):

	 * dump data up to cap_len ignoring small duplicate in rec->payload

	 */

	spin_lock_irqsave(&dbf->pay_lock, flags);

	spin_lock(&dbf->pay_lock);

	memset(payload, 0, sizeof(*payload));

	memcpy(payload->area, paytag, ZFCP_DBF_TAG_LEN);

	payload->fsf_req_id = req_id;