Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e6f3b63f authored by Mike Christie's avatar Mike Christie Committed by James Bottomley
Browse files

[SCSI] iscsi: rm channel usage from iscsi 



I do not remember what I was thinking when we added the channel
as a argument to the session create function. It was probably
due to too much cut and paste work from the FC transport class.

The channel is meaningless for iscsi drivers so this patch drops
its usage everywhere in the iscsi related code.

Signed-off-by: default avatarMike Christie <michaelc@cs.wisc.edu>
Signed-off-by: default avatarJames Bottomley <James.Bottomley@SteelEye.com>
parent f53a88da

drivers/scsi/libiscsi.c

+1 −1
Original line number Diff line number Diff line
@@ -1290,7 +1290,7 @@ iscsi_session_setup(struct iscsi_transport *iscsit, 
	if (!try_module_get(iscsit->owner))

		goto cls_session_fail;



	cls_session = iscsi_create_session(shost, iscsit, 0);

	cls_session = iscsi_create_session(shost, iscsit);

	if (!cls_session)

		goto module_put;

	*(unsigned long*)shost->hostdata = (unsigned long)cls_session;

drivers/scsi/scsi_transport_iscsi.c

+3 −5
Original line number Diff line number Diff line
@@ -248,10 +248,9 @@ static int iscsi_user_scan(struct Scsi_Host *shost, uint channel, 


	mutex_lock(&ihost->mutex);

	list_for_each_entry(session, &ihost->sessions, host_list) {

		if ((channel == SCAN_WILD_CARD ||

		     channel == session->channel) &&

		if ((channel == SCAN_WILD_CARD || channel == 0) &&

		    (id == SCAN_WILD_CARD || id == session->target_id))

			scsi_scan_target(&session->dev, session->channel,

			scsi_scan_target(&session->dev, 0,

					 session->target_id, lun, 1);

	}

	mutex_unlock(&ihost->mutex);
@@ -297,7 +296,7 @@ EXPORT_SYMBOL_GPL(iscsi_block_session); 
 **/

struct iscsi_cls_session *

iscsi_create_session(struct Scsi_Host *shost,

		     struct iscsi_transport *transport, int channel)

		     struct iscsi_transport *transport)

{

	struct iscsi_host *ihost;

	struct iscsi_cls_session *session;
@@ -322,7 +321,6 @@ iscsi_create_session(struct Scsi_Host *shost, 
	ihost = shost->shost_data;



	session->sid = iscsi_session_nr++;

	session->channel = channel;

	session->target_id = ihost->next_target_id++;



	snprintf(session->dev.bus_id, BUS_ID_SIZE, "session%u",

include/scsi/scsi_transport_iscsi.h

+1 −2
Original line number Diff line number Diff line
@@ -187,7 +187,6 @@ struct iscsi_cls_session { 
	struct work_struct recovery_work;



	int target_id;

	int channel;



	int sid;				/* session id */

	void *dd_data;				/* LLD private data */
@@ -210,7 +209,7 @@ struct iscsi_host { 
 * session and connection functions that can be used by HW iSCSI LLDs

 */

extern struct iscsi_cls_session *iscsi_create_session(struct Scsi_Host *shost,

				struct iscsi_transport *t, int channel);

						struct iscsi_transport *t);

extern int iscsi_destroy_session(struct iscsi_cls_session *session);

extern struct iscsi_cls_conn *iscsi_create_conn(struct iscsi_cls_session *sess,

					    uint32_t cid);