Commit e3e5fc91 authored Sep 30, 2006 by Paul Collins Committed by Linus Torvalds Oct 01, 2006

[PATCH] leds: turn LED off when changing triggers



I was playing with LED triggers when I noticed that changing from heartbeat
(or ide-disk) to "none" at the right moment would leave the LED stuck on.
This is easy to reproduce by doing "find / >/dev/null" with the ide-disk
trigger enabled and then switching to "none".

Here is a patch that fixes the problem by explicitly turning the LED off
after removing the existing trigger.

Signed-off-by: Paul Collins <paul@ondioline.org>
Acked-by: Richard Purdie <rpurdie@rpsys.net>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent fd7bcea3

drivers/leds/led-triggers.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -125,6 +125,7 @@ void led_trigger_set(struct led_classdev led_cdev, struct led_trigger trigger)
		write_unlock_irqrestore(&led_cdev->trigger->leddev_list_lock, flags);
		if (led_cdev->trigger->deactivate)
		led_cdev->trigger->deactivate(led_cdev);
		led_set_brightness(led_cdev, LED_OFF);
		}
		if (trigger) {
		write_lock_irqsave(&trigger->leddev_list_lock, flags);