Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d7f7dc7b authored Jun 26, 2017 by Colin Ian King Committed by Thomas Gleixner Jun 26, 2017

x86/microcode: Make a couple of symbols static



The helper function __load_ucode_amd() and pointer intel_ucode_patch do
not need to be in global scope, so make them static.

Fixes those sparse warnings:
"symbol '__load_ucode_amd' was not declared. Should it be static?"
"symbol 'intel_ucode_patch' was not declared. Should it be static?"

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/20170622095736.11937-1-colin.king@canonical.com

parent bd207330

arch/x86/kernel/cpu/microcode/amd.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -251,7 +251,7 @@ static bool get_builtin_microcode(struct cpio_data *cp, unsigned int family)
	#endif		#endif
	}		}

	void __load_ucode_amd(unsigned int cpuid_1_eax, struct cpio_data *ret)		static void __load_ucode_amd(unsigned int cpuid_1_eax, struct cpio_data *ret)
	{		{
	struct ucode_cpu_info *uci;		struct ucode_cpu_info *uci;
	struct cpio_data cp;		struct cpio_data cp;

arch/x86/kernel/cpu/microcode/intel.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -42,7 +42,7 @@
	static const char ucode_path[] = "kernel/x86/microcode/GenuineIntel.bin";		static const char ucode_path[] = "kernel/x86/microcode/GenuineIntel.bin";

	/* Current microcode patch used in early patching on the APs. */		/* Current microcode patch used in early patching on the APs. */
	struct microcode_intel *intel_ucode_patch;		static struct microcode_intel *intel_ucode_patch;

	static inline bool cpu_signatures_match(unsigned int s1, unsigned int p1,		static inline bool cpu_signatures_match(unsigned int s1, unsigned int p1,
	unsigned int s2, unsigned int p2)		unsigned int s2, unsigned int p2)