Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d4ffeecb authored by Fabio Estevam's avatar Fabio Estevam Committed by Wolfram Sang
Browse files

i2c: imx+mxs: Use the preferred form for passing a size of a struct 



According to Documentation/CodingStyle - Chapter 14:

"The preferred form for passing a size of a struct is the following:

	p = kmalloc(sizeof(*p), ...);

The alternative form where struct name is spelled out hurts readability and
introduces an opportunity for a bug when the pointer variable type is changed
but the corresponding sizeof that is passed to a memory allocator is not."

So do it as recommeded.

Signed-off-by: default avatarFabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: default avatarWolfram Sang <wsa@the-dreams.de>
parent 206c5f60

drivers/i2c/busses/i2c-imx.c

+1 −2
Original line number Original line Diff line number Diff line
@@ -668,8 +668,7 @@ static int i2c_imx_probe(struct platform_device *pdev) 
	if (IS_ERR(base))

	if (IS_ERR(base))

		return PTR_ERR(base);

		return PTR_ERR(base);





	i2c_imx = devm_kzalloc(&pdev->dev, sizeof(struct imx_i2c_struct),

	i2c_imx = devm_kzalloc(&pdev->dev, sizeof(*i2c_imx), GFP_KERNEL);

				GFP_KERNEL);

	if (!i2c_imx)

	if (!i2c_imx)

		return -ENOMEM;

		return -ENOMEM;

drivers/i2c/busses/i2c-mxs.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -811,7 +811,7 @@ static int mxs_i2c_probe(struct platform_device *pdev) 
	struct resource *res;

	struct resource *res;

	int err, irq;

	int err, irq;





	i2c = devm_kzalloc(dev, sizeof(struct mxs_i2c_dev), GFP_KERNEL);

	i2c = devm_kzalloc(dev, sizeof(*i2c), GFP_KERNEL);

	if (!i2c)

	if (!i2c)

		return -ENOMEM;

		return -ENOMEM;